[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request: Porting Bomber from KGameCanvas to QGraphicsView
From: "Parker Coates" <coates () kde ! org>
Date: 2012-03-13 15:43:18
Message-ID: 20120313154318.23954.12195 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 12, 2012, 7:01 p.m., Stefan Majewsky wrote:
> > trunk/KDE/kdegames/bomber/src/bomberwidget.cpp, lines 356-357
> > <http://svn.reviewboard.kde.org/r/6908/diff/2/?file=47695#file47695line356>
> >
> > You're looking for QGraphicsItem::setZValue.
>
> Mehmet Emre wrote:
> I've used removeItem and addItem instead of setZValue because if I'd use setZValue \
> then I'd find a way to make sure that m_overlay's Z-Value is greater than all of \
> the other items' Z-Values.
Typically we just use an arbitrarily large zValue for this kind of thing, like 1000, \
which is unlikely to be exceeded by a scene that contains significantly less than \
1000 items. This allows you to do multiple "layers". Background stuff starts at \
-1000, main content at 0 and overlays at 1000, for example.
- Parker
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6908/#review10721
-----------------------------------------------------------
On March 13, 2012, 9:28 a.m., Mehmet Emre wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6908/
> -----------------------------------------------------------
>
> (Updated March 13, 2012, 9:28 a.m.)
>
>
> Review request for KDE Games.
>
>
> Description
> -------
>
> I've ported bomber to QGraphicsView as requested here: \
> http://techbase.kde.org/Projects/Games/Porting. I've made some modifications on the \
> classes below:
> - Explodable
> - BomberBoard
> - BomberGameWidget
> - Building
>
>
> Diffs
> -----
>
> trunk/KDE/kdegames/bomber/src/board.h 1284898
> trunk/KDE/kdegames/bomber/src/board.cpp 1284898
> trunk/KDE/kdegames/bomber/src/bomberwidget.h 1284898
> trunk/KDE/kdegames/bomber/src/bomberwidget.cpp 1284898
> trunk/KDE/kdegames/bomber/src/building.h 1284898
> trunk/KDE/kdegames/bomber/src/building.cpp 1284898
> trunk/KDE/kdegames/bomber/src/explodable.h 1284898
> trunk/KDE/kdegames/bomber/src/explodable.cpp 1284898
>
> Diff: http://svn.reviewboard.kde.org/r/6908/diff/
>
>
> Testing
> -------
>
> I've done these tests and solved the problems that I've bumped into:
> - Played bomber's first two levels.
> - Paused the game
> - Changed settings during the game and while game is paused.
>
>
> Thanks,
>
> Mehmet Emre
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6908/">http://svn.reviewboard.kde.org/r/6908/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 12th, 2012, 7:01 p.m., <b>Stefan \
Majewsky</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6908/diff/2/?file=47695#file47695line356" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdegames/bomber/src/bomberwidget.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
BomberGameWidget::generateOverlay()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">344</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">m_board</span><span class="o">-></span><span \
class="n">removeItem</span><span class="p">(</span><span \
class="n">m_overlay</span><span class="p">);</span> <span class="c1">// Equivalent of \
raise()</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">345</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">m_board</span><span class="o">-></span><span \
class="n">addItem</span><span class="p">(</span><span class="n">m_overlay</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're looking for \
QGraphicsItem::setZValue.</pre> </blockquote>
<p>On March 13th, 2012, 11:54 a.m., <b>Mehmet Emre</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've used removeItem \
and addItem instead of setZValue because if I'd use setZValue then I'd find a \
way to make sure that m_overlay's Z-Value is greater than all of the other \
items' Z-Values.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Typically \
we just use an arbitrarily large zValue for this kind of thing, like 1000, which is \
unlikely to be exceeded by a scene that contains significantly less than 1000 items. \
This allows you to do multiple "layers". Background stuff starts at -1000, \
main content at 0 and overlays at 1000, for example.</pre> <br />
<p>- Parker</p>
<br />
<p>On March 13th, 2012, 9:28 a.m., Mehmet Emre wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Mehmet Emre.</div>
<p style="color: grey;"><i>Updated March 13, 2012, 9:28 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've ported bomber to QGraphicsView as requested here: \
http://techbase.kde.org/Projects/Games/Porting. I've made some modifications on \
the classes below:
- Explodable
- BomberBoard
- BomberGameWidget
- Building</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've done these tests and solved the problems that I've bumped \
into:
- Played bomber's first two levels.
- Paused the game
- Changed settings during the game and while game is paused.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/bomber/src/board.h <span style="color: \
grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/board.cpp <span style="color: \
grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/bomberwidget.h <span style="color: \
grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/bomberwidget.cpp <span style="color: \
grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/building.h <span style="color: \
grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/building.cpp <span style="color: \
grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/explodable.h <span style="color: \
grey">(1284898)</span></li>
<li>trunk/KDE/kdegames/bomber/src/explodable.cpp <span style="color: \
grey">(1284898)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6908/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic