[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    [Kde-games-devel] Re: KGoldrunner now uses TagaroAudio,
From:       Parker Coates <parker.coates () kdemail ! net>
Date:       2011-05-11 13:54:09
Message-ID: BANLkTikAC2KvjWeC3GfqVOSJ8qp5E-t3vw () mail ! gmail ! com
[Download RAW message or body]

On Wed, May 11, 2011 at 05:02, Ian Wadham wrote:
> On Tuesday 10 May 2011 7:54:15 am Mathias Kraus wrote:
>> If you want to make OpenAL and SndFile a hard dependency for KGoldrunner,
>>  I'd also make it a hard dependency for granatier because the sound is so
>>  much better and I think if two games use it, it might be a good reason for
>>  a hard dependency.
>>
> Yes I do want to make OpenAL and SndFile a hard dependency for KGoldrunner.
> Tomorrow is the last day to decide for Granatier.  Did you see my last reply?
>
> I am poised, ready to commit (first thing Thursday) a version of
> kgoldrunner/CMakeLists.txt that has the line:
>    find_package(OpenAL REQUIRED)
> instead of:
>    macro_optional_find_package(OpenAL QUIET)
>
> I am not sure if this is the correct way to do it.  OpenAL *still* lists as an
> optional external package during the kdegames build.  But at least,
> KGoldrunner fails to build if OpenAL is not found.  Will the Release Team
> pick up on that?  Or should I warn them?

Hello Ian,

You should also update kdegames/CMakeLists.txt to check for OpenAL and
SndFile and then attempt to build KGoldrunner only if they're found,
much the same as is already done for OpenGL, QCA and Python.

Parker
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread]