[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    [Kde-games-devel] Re: KGoldrunner now uses TagaroAudio,
From:       Ian Wadham <iandw.au () gmail ! com>
Date:       2011-05-11 9:02:01
Message-ID: 201105111902.01635.iandw.au () gmail ! com
[Download RAW message or body]

On Tuesday 10 May 2011 7:54:15 am Mathias Kraus wrote:
> Ian Wadham schrieb am Montag, 9. Mai 2011:
> > I have just committed a version of KGoldrunner that uses a clone
> > of TagaroAudio (from Granatier)
> 
> > Question: Do I need to tell the Release Team about the new
> > dependency?  I'd hate to have KGr going out without sound
> > because someone in the chain does not have devel versions
> > of OpenAL and SndFile.  OTOH Granatier is already dependent
> > on OpenAL, etc., but will revert to Phonon if they are not present.
> 
> If you want to make OpenAL and SndFile a hard dependency for KGoldrunner,
>  I'd also make it a hard dependency for granatier because the sound is so
>  much better and I think if two games use it, it might be a good reason for
>  a hard dependency.
> 
Yes I do want to make OpenAL and SndFile a hard dependency for KGoldrunner.
Tomorrow is the last day to decide for Granatier.  Did you see my last reply?

I am poised, ready to commit (first thing Thursday) a version of
kgoldrunner/CMakeLists.txt that has the line:
    find_package(OpenAL REQUIRED)
instead of:
    macro_optional_find_package(OpenAL QUIET)

I am not sure if this is the correct way to do it.  OpenAL *still* lists as an
optional external package during the kdegames build.  But at least,
KGoldrunner fails to build if OpenAL is not found.  Will the Release Team
pick up on that?  Or should I warn them?

Living in Australia, I have several hours' start on this :-)
My 23:59 is UTC's 13:59 ... :-) ...  10 hours ...

Mathias, that should give you time to see this email before I
commit on Thursday morning (Aust time) and say whether
Granatier will also declare a hard dependency on OpenAL.

All the best, Ian W.
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]