[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: [Kde-games-devel] Re: Review Request: Make the default renderSize
From: "Parker Coates" <parker.coates () kdemail ! net>
Date: 2010-10-11 21:42:25
Message-ID: 20101011214225.21459.86907 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-09 09:03:44, Frederik Schwarzer wrote:
> > Can you close this review please?
Sorry. The last time I tried to close this review, ReviewBoard crashed. Wil=
l try again. :)
- Parker
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5380/#review8057
-----------------------------------------------------------
On 2010-09-18 20:22:58, Parker Coates wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5380/
> -----------------------------------------------------------
> =
> (Updated 2010-09-18 20:22:58)
> =
> =
> Review request for KDE Games.
> =
> =
> Summary
> -------
> =
> Currently, KGameRendererClients are created with a default renderSize of =
3x3. This patch changes the default to an invalid size so that no rendering=
is done until a valid renderSize is given. This both saves some totally un=
necessary rendering and is more likely to match the expectations of users o=
f KGRC.
> =
> I was just trying to fix a bug in KPat that I eventually tracked down to =
an unexpected item paint event happening with a 3x3 pixmap. The issue was i=
ntermittent due to a race condition between the KGameRenderer's threaded re=
ndering and Qt's delayed painting making it tricky to track down. Anyway, o=
nce I found the source of the 3x3 size, the issue was easy enough to work a=
round, but I'd rather not see other devs hit similar issues.
> =
> Stefan, is this behaviour intentional? Is there any chance that this patc=
h could cause breakages inside KGameRenderer?
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdegames/libkdegames/kgamerendererclient.cpp 1176563 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5380/diff
> =
> =
> Testing
> -------
> =
> Tried several of the games ported to KGR and saw no regressions. I doubt =
any one was depending on the default renderSize being non-empty.
> =
> =
> Thanks,
> =
> Parker
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5380/">http://svn.reviewboard.kde.org/r/5380/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 9th, 2010, 9:03 a.m., <b>Frederik \
Schwarzer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Can you close this review please?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry. The last time I \
tried to close this review, ReviewBoard crashed. Will try again. :)</pre> <br />
<p>- Parker</p>
<br />
<p>On September 18th, 2010, 8:22 p.m., Parker Coates wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Parker Coates.</div>
<p style="color: grey;"><i>Updated 2010-09-18 20:22:58</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, KGameRendererClients are created with a default renderSize of \
3x3. This patch changes the default to an invalid size so that no rendering is done \
until a valid renderSize is given. This both saves some totally unnecessary rendering \
and is more likely to match the expectations of users of KGRC.
I was just trying to fix a bug in KPat that I eventually tracked down to an \
unexpected item paint event happening with a 3x3 pixmap. The issue was intermittent \
due to a race condition between the KGameRenderer's threaded rendering and \
Qt's delayed painting making it tricky to track down. Anyway, once I found the \
source of the 3x3 size, the issue was easy enough to work around, but I'd rather \
not see other devs hit similar issues.
Stefan, is this behaviour intentional? Is there any chance that this patch could \
cause breakages inside KGameRenderer?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tried several of the games ported to KGR and saw no regressions. I doubt \
any one was depending on the default renderSize being non-empty.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/libkdegames/kgamerendererclient.cpp <span style="color: \
grey">(1176563)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5380/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic