[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request: Added difficuly level into
From: "Andreas Scherf" <ascherfy () googlemail ! com>
Date: 2010-03-18 21:03:09
Message-ID: 20100318210309.13225.32909 () localhost
[Download RAW message or body]
> On 2010-03-18 20:13:11, Frederik Schwarzer wrote:
> > I cannot say anything about the change. I currently do not have enough time to \
> > dig into the code and such ... so here is some nitpicking. ;)
Hi, thanks. About the indentation. It seems that the original code usese tabs for \
indentation. I have 4 spaces as indentation level. If i open the code in kate for \
example it looks clean. But the diff looks ugly. What to do? Reformat the whole \
source? Use tabs instead of spaces? Some of the parts you mentioned are corrected.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3077/#review4555
-----------------------------------------------------------
On 2010-03-01 19:52:39, Andreas Scherf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3077/
> -----------------------------------------------------------
>
> (Updated 2010-03-01 19:52:39)
>
>
> Review request for KDE Games.
>
>
> Summary
> -------
>
> Fullfilled the wishlist item 219507. I added 3 difficulty levels into kbounce \
> (easy,medium,hard) Medium hat the default settings and (Easy,Hard) have different \
> velocity settings for walls and balls. The problem is now is Difficulty:Hard \
> playable anymore?
>
> This addresses bug 219507.
> https://bugs.kde.org/show_bug.cgi?id=219507
>
>
> Diffs
> -----
>
> /trunk/KDE/kdegames/kbounce/backgroundselector.cpp 1097314
> /trunk/KDE/kdegames/kbounce/board.h 1097314
> /trunk/KDE/kdegames/kbounce/board.cpp 1097314
> /trunk/KDE/kdegames/kbounce/gamewidget.h 1097314
> /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1097314
> /trunk/KDE/kdegames/kbounce/main.cpp 1097314
> /trunk/KDE/kdegames/kbounce/mainwindow.h 1097314
> /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1097314
> /trunk/KDE/kdegames/kbounce/wall.h 1097314
> /trunk/KDE/kdegames/kbounce/wall.cpp 1097314
>
> Diff: http://reviewboard.kde.org/r/3077/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas
>
>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic