[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request: Added difficuly level into
From:       "Frederik Schwarzer" <schwarzerf () gmail ! com>
Date:       2010-03-18 20:13:03
Message-ID: 20100318201303.9855.46777 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3077/#review4555
-----------------------------------------------------------


I cannot say anything about the change. I currently do not have enough time to dig \
into the code and such ... so here is some nitpicking. ;)


/trunk/KDE/kdegames/kbounce/board.h
<http://reviewboard.kde.org/r/3077/#comment4003>

    indentation



/trunk/KDE/kdegames/kbounce/board.h
<http://reviewboard.kde.org/r/3077/#comment4004>

    indentation



/trunk/KDE/kdegames/kbounce/gamewidget.h
<http://reviewboard.kde.org/r/3077/#comment4005>

    indentation



/trunk/KDE/kdegames/kbounce/gamewidget.h
<http://reviewboard.kde.org/r/3077/#comment4006>

    indentation



/trunk/KDE/kdegames/kbounce/gamewidget.cpp
<http://reviewboard.kde.org/r/3077/#comment4007>

    whitespace



/trunk/KDE/kdegames/kbounce/main.cpp
<http://reviewboard.kde.org/r/3077/#comment4002>

    "Some work." is not worth mentioning. Please be more specific, even if it is only \
"Some improvements and fixes" or something similar.



/trunk/KDE/kdegames/kbounce/mainwindow.cpp
<http://reviewboard.kde.org/r/3077/#comment4009>

    indentation



/trunk/KDE/kdegames/kbounce/mainwindow.cpp
<http://reviewboard.kde.org/r/3077/#comment4008>

    indentation



/trunk/KDE/kdegames/kbounce/wall.h
<http://reviewboard.kde.org/r/3077/#comment4010>

    indentation



/trunk/KDE/kdegames/kbounce/wall.h
<http://reviewboard.kde.org/r/3077/#comment4011>

    indentation



/trunk/KDE/kdegames/kbounce/wall.cpp
<http://reviewboard.kde.org/r/3077/#comment4012>

    whitespace



/trunk/KDE/kdegames/kbounce/wall.cpp
<http://reviewboard.kde.org/r/3077/#comment4013>

    whitespace



/trunk/KDE/kdegames/kbounce/wall.cpp
<http://reviewboard.kde.org/r/3077/#comment4014>

    whitespace



/trunk/KDE/kdegames/kbounce/wall.cpp
<http://reviewboard.kde.org/r/3077/#comment4015>

    whitespace



/trunk/KDE/kdegames/kbounce/wall.cpp
<http://reviewboard.kde.org/r/3077/#comment4016>

    whitespace



/trunk/KDE/kdegames/kbounce/wall.cpp
<http://reviewboard.kde.org/r/3077/#comment4017>

    whitespace


- Frederik


On 2010-03-01 19:52:39, Andreas Scherf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3077/
> -----------------------------------------------------------
> 
> (Updated 2010-03-01 19:52:39)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> Fullfilled the wishlist item 219507. I added 3 difficulty levels into kbounce \
> (easy,medium,hard) Medium hat the default settings and (Easy,Hard) have different \
> velocity settings for walls and balls. The problem is now is Difficulty:Hard \
> playable anymore? 
> 
> This addresses bug 219507.
> https://bugs.kde.org/show_bug.cgi?id=219507
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdegames/kbounce/backgroundselector.cpp 1097314 
> /trunk/KDE/kdegames/kbounce/board.h 1097314 
> /trunk/KDE/kdegames/kbounce/board.cpp 1097314 
> /trunk/KDE/kdegames/kbounce/gamewidget.h 1097314 
> /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1097314 
> /trunk/KDE/kdegames/kbounce/main.cpp 1097314 
> /trunk/KDE/kdegames/kbounce/mainwindow.h 1097314 
> /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1097314 
> /trunk/KDE/kdegames/kbounce/wall.h 1097314 
> /trunk/KDE/kdegames/kbounce/wall.cpp 1097314 
> 
> Diff: http://reviewboard.kde.org/r/3077/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas
> 
> 

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel


[prev in list] [next in list] [prev in thread] [next in thread]