[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    [Kde-games-devel] Review Request: Threaded card rendering in LSkat
From:       "Parker Coates" <parker.coates () gmail ! com>
Date:       2009-06-03 1:23:51
Message-ID: 20090603012351.25985.26104 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/792/
-----------------------------------------------------------

Review request for KDE Games.


Summary
-------

As describe here (http://reviewboard.kde.org/r/676/), some optimisations have been \
made to KCardCache to allow the loading of SVG files and rendering of card graphics \
in the background. KPat has already been modified to take advantage of this \
functionality, but LSkat has not.

This patch attempts to add threaded loading to LSkat. The implementation isn't the \
most elegant, but it is relatively simple. This is my first time looking at the LSkat \
code, so feedback is definitely appreciated.


Diffs
-----

  trunk/KDE/kdegames/lskat/src/thememanager.h 973384 
  trunk/KDE/kdegames/lskat/src/thememanager.cpp 973384 

Diff: http://reviewboard.kde.org/r/792/diff


Testing
-------

I've changed decks and changed the window size a few dozen times. I've also played \
through a few games. Thus far I've notice no ill effects.


Thanks,

Parker

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel


[prev in list] [next in list] [prev in thread] [next in thread]