[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    [Kde-games-devel] Review Request: KMines: fix the problem,
From:       "Clemens Werther" <cl3m3ns () googlemail ! com>
Date:       2009-02-22 23:15:51
Message-ID: 20090222231551.12757.83301 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/158/
-----------------------------------------------------------

Review request for KDE Games.


Summary
-------

Change 1 and 5:
This puts the "first-click-detection" routine where it belongs.

Change 2:
press left; press mid; release left; move mouse over another cell; press left; \
release mid; release left

Without the change, the timer would start, although no item is revealed (only really \
visible after applying change 1 and 5, because without, the timer even starts when \
any mouse button is down... ).  
Change 3 and 4:
press left; press mid; release left; release mid

Without the change, this would result in a pressed item, although the mouse is not \
pressed anymore.


After applying the whole patch, situations like the one in the screenshot shouldn't \
be possible anymore.


Diffs
-----

  trunk/KDE/kdegames/kmines/minefielditem.cpp 925889 

Diff: http://reviewboard.kde.org/r/158/diff


Testing
-------


Screenshots
-----------

fail at first click
  http://reviewboard.kde.org/r/158/s/29/


Thanks,

Clemens

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel


[prev in list] [next in list] [prev in thread] [next in thread]