[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Cosmetic patch for kmahjongg
From:       Dave Corrie <kde () davecorrie ! com>
Date:       2003-05-21 10:33:38
[Download RAW message or body]

On Tuesday 20 May 2003 11:46 pm, Médéric BOQUIEN wrote:
> Thank you for integrating my previous tiny patch. Here is another
> one. It is purely cosmetic. It permits to align vertically the titles
> in the highscores. Without this patch, "Name", "Score" and "Time" are
> lower than "Pos" and "Board". Default QT behaviour for alignment
> seems to work better. The diff is against HEAD from this evening.

Wow, you've got good eyesight: they're only 1 pixel out of line on my 
screen!

Committed to HEAD. Thanks!

> P.S : is there a document explaining how to make clean patches? I
> have checked patches from developpers on kde-devel and they seem more
> path independant. I fear mines can't always work as is.

If you're using anonymous cvs and you have your ~/.cvsrc file set up as 
shown on http://developer.kde.org/source/anoncvs.html, then you can use 
the following command to generate patches:

cvs diff > filename.patch

Having said that, the format in which you have sent patches is fine 
because the patch program is quite happy to ignore the paths listed in 
the header.

Cheers,

Dave
_______________________________________________
kde-games-devel mailing list
kde-games-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]