[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Breeze and ECM are incompatible for installing icons
From:       Carl Schwan <carl () carlschwan ! eu>
Date:       2023-11-03 9:13:15
Message-ID: 3338831.44csPzL39Z () fedora
[Download RAW message or body]

On Friday, November 3, 2023 12:46:20 AM CET Albert Astals Cid wrote:
> El dijous, 2 de novembre de 2023, a les 14:36:16 (CET), David Jarvie va
> 
> escriure:
> > Breeze installs its icons in a different directory structure from other
> > icon themes, with the result that the ECM cmake command ecm_install_icons
> > doesn't work for Breeze icons. The only way to install an application
> > specific Breeze icon is to hard code its location, for example
> > "${KDE_INSTALL_ICONDIR}/breeze/actions/22/".
> 
> Why are you installing icons in breeze icon theme if you're not the breeze
> icon theme?
> 
> Seems wrong to me.

Yes, it's wrong. We made the same mistake in Tokodon and the correct way to do 
it is to install in the hicolor theme. This allow the theme to overwrite the 
icon if they want and don't force you to hardcode the breeze icon theme.


[prev in list] [next in list] [prev in thread] [next in thread]