[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D27355: POC: Make kstatusnotifieritem available without dbus
From:       Johnny Jazeix <noreply () phabricator ! kde ! org>
Date:       2020-02-13 7:37:07
Message-ID: 24411e5902619022399729cccc0966da () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jjazeix added a comment.


  thank you!
  I did the same but way worse.
  I think we can at least push this fix to remove all failing jobs then \
clean it up?

INLINE COMMENTS

> CMakeLists.txt:94
> if (NOT WIN32 AND NOT ANDROID)
> find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus)
> find_package(Canberra)

this is not the aim of this diff, but I looked at the code, I found this \
line was duplicated from line 43

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27355

To: vonreth, bcooksley, jjazeix
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


[Attachment #3 (text/html)]

<table><tr><td style="">jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27355">View \
Revision</a></tr></table><br /><div><div><p>thank you!<br /> I did the same \
but way worse.<br /> I think we can at least push this fix to remove all \
failing jobs then clean it up?</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: \
0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D27355#inline-154478">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:94</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">if (NOT WIN32 AND NOT ANDROID) \
</div><div style="padding: 0 8px; margin: 0 4px; ">    find_package(Qt5 \
${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus) </div><div style="padding: 0 \
8px; margin: 0 4px; ">    find_package(Canberra) </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">this is not the aim of this diff, but I looked at the code, I found \
this line was duplicated from line 43</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R289 \
KNotifications</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D27355">https://phabricator.kde.org/D27355</a></div></div><br \
/><div><strong>To: </strong>vonreth, bcooksley, jjazeix<br /><strong>Cc: \
</strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, \
bruns<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]