[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D27355: POC: Make kstatusnotifieritem available without dbus
From:       Ben Cooksley <noreply () phabricator ! kde ! org>
Date:       2020-02-13 6:45:44
Message-ID: 536e6ccd8581bf77da5242af13db51e3 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

bcooksley added inline comments.

INLINE COMMENTS

> kstatusnotifieritem.cpp:48
> +
> +#include <QTimer>
> #include <kwindowinfo.h>

New header?

> kstatusnotifieritem.cpp:617
> void KStatusNotifierItem::showMessage(const QString &title, const QString \
> &message, const QString &icon, int timeout) {
> #ifdef Q_OS_MACOS

Won't this mean that showMessage() is a no-op on Windows systems without \
D-Bus? I would have thought that systemTrayIcon->showMessage() should be \
used here as well?

> kstatusnotifieritem.cpp:888
> {
> +    bool useLegacy = false;
> +#ifdef QT_DBUS_LIB

From my reading of the setLegacySystemTrayEnabled() won't setting it to \
false explicitly disable any form of system tray icon?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27355

To: vonreth, bcooksley, jjazeix
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


[Attachment #3 (text/html)]

<table><tr><td style="">bcooksley added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27355">View \
Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: \
0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D27355#inline-154477">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kstatusnotifieritem.cpp:48</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span style="color: #304a96">#include</span> <span \
class="cpf">&lt;QTimer&gt;</span><span style="color: #304a96"></span> \
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: \
#304a96">#include</span> <span \
class="cpf">&lt;kwindowinfo.h&gt;</span><span style="color: \
#304a96"></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">New header?</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; \
margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px \
8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D27355#inline-154475">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kstatusnotifieritem.cpp:617</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "><span style="color: \
#aa4000">void</span> <span class="n">KStatusNotifierItem</span><span \
style="color: #aa2211">::</span><span class="n">showMessage</span><span \
class="p">(</span><span style="color: #aa4000">const</span> <span \
class="n">QString</span> <span style="color: #aa2211">&amp;</span><span \
class="n">title</span><span class="p">,</span> <span style="color: \
#aa4000">const</span> <span class="n">QString</span> <span style="color: \
#aa2211">&amp;</span><span class="n">message</span><span class="p">,</span> \
<span style="color: #aa4000">const</span> <span class="n">QString</span> \
<span style="color: #aa2211">&amp;</span><span class="n">icon</span><span \
class="p">,</span> <span style="color: #aa4000">int</span> <span \
class="n">timeout</span><span class="p">)</span> </div><div style="padding: \
0 8px; margin: 0 4px; "><span class="p">{</span> </div><div style="padding: \
0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span \
style="color: #aa4000">if</span> <span class="p">(</span><span \
style="color: #aa2211">!</span><span class="n">d</span><span style="color: \
#aa2211">-&gt;</span><span class="n">notificationsClient</span><span \
class="p">)</span> <span class="p">{</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span \
class="n">d</span><span style="color: #aa2211">-&gt;</span><span \
class="n">notificationsClient</span> <span style="color: #aa2211">=</span> \
<span style="color: #aa4000">new</span> <span class="n">org</span><span \
style="color: #aa2211">::</span><span class="n">freedesktop</span><span \
style="color: #aa2211">::</span><span class="n">Notifications</span><span \
class="p">(</span><span class="n">QStringLiteral</span><span \
class="p">(</span><span style="color: \
#766510">&quot;org.freedesktop.Notifications&quot;</span><span \
class="p">),</span> <span class="n">QStringLiteral</span><span \
class="p">(</span><span style="color: \
#766510">&quot;/org/freedesktop/Notifications&quot;</span><span \
class="p">),</span> </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);">                <span \
class="n">QDBusConnection</span><span style="color: #aa2211">::</span><span \
class="n">sessionBus</span><span class="p">());</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">    <span class="p">}</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">    <span class="n">uint</span> <span class="n">id</span> <span \
style="color: #aa2211">=</span> <span style="color: #601200">0</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; "><span \
style="color: #304a96">#ifdef Q_OS_MACOS</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Won&#039;t this mean that showMessage() is a no-op on Windows systems \
without D-Bus?<br /> I would have thought that \
systemTrayIcon-&gt;showMessage() should be used here as \
well?</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; \
margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px \
8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D27355#inline-154476">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">kstatusnotifieritem.cpp:888</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span style="color: #aa4000">bool</span> <span \
class="n">useLegacy</span> <span style="color: #aa2211">=</span> <span \
style="color: #304a96">false</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span style="color: #304a96">#ifdef QT_DBUS_LIB</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">From my reading of the \
setLegacySystemTrayEnabled() won&#039;t setting it to false explicitly \
disable any form of system tray icon?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R289 \
KNotifications</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D27355">https://phabricator.kde.org/D27355</a></div></div><br \
/><div><strong>To: </strong>vonreth, bcooksley, jjazeix<br /><strong>Cc: \
</strong>kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, \
bruns<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]