[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason strin
From: Anthony Fieroni <bvbfan () abv ! bg>
Date: 2016-12-18 8:33:42
Message-ID: 20161218083342.11011.11121 () mimi ! kde ! org
[Download RAW message or body]
--===============7292426159115828534==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Дек. 17, 2016, 5:53 след обяд, Martin Klapetek wrote:
> > Just because it "looks annoying" doesn't mean it doesn't have its use.
> >
> > I'll do the git-blame-search for you: \
> > https://cgit.kde.org/knotifications.git/commit/?id=3f080d44af41d0158d7b5c51269449e78d5b128f
> >
>
> Anthony Fieroni wrote:
> I will correct GwenView too, about me this patch is at wrong place
>
> Martin Klapetek wrote:
> This is not about Gwenview, this is about safe API that won't break with any other \
> app actually not providing the reason.
> Please leave this part alone.
It's same safe api, it will be safe.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129666/#review101483
-----------------------------------------------------------
On Дек. 17, 2016, 5:48 след обяд, Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129666/
> -----------------------------------------------------------
>
> (Updated Дек. 17, 2016, 5:48 след обяд)
>
>
> Review request for KDE Frameworks and Martin Klapetek.
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> "no_reason_specified" looks annoying reason
>
>
> Diffs
> -----
>
> src/knotificationrestrictions.h e9179ae
> src/knotificationrestrictions.cpp 5f5d908
>
> Diff: https://git.reviewboard.kde.org/r/129666/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============7292426159115828534==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129666/">https://git.reviewboard.kde.org/r/129666/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Декември 17th, 2016, 5:53 след \
обяд EET, <b>Martin Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Just because it "looks \
annoying" doesn't mean it doesn't have its use. </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll \
do the git-blame-search for you: \
https://cgit.kde.org/knotifications.git/commit/?id=3f080d44af41d0158d7b5c51269449e78d5b128f</p></pre>
</blockquote>
<p>On Декември 17th, 2016, 7:17 след обяд EET, <b>Anthony \
Fieroni</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I will correct GwenView too, about me this patch is at \
wrong place</p></pre> </blockquote>
<p>On Декември 17th, 2016, 8:02 след обяд EET, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is not about Gwenview, this is about safe API \
that won't break with any other app actually not providing the reason.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please leave this part alone.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
same safe api, it will be safe.</p></pre> <br />
<p>- Anthony</p>
<br />
<p>On Декември 17th, 2016, 5:48 след обяд EET, Anthony Fieroni \
wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Martin Klapetek.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Дек. 17, 2016, 5:48 след обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">"no_reason_specified" looks annoying reason</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/knotificationrestrictions.h <span style="color: grey">(e9179ae)</span></li>
<li>src/knotificationrestrictions.cpp <span style="color: \
grey">(5f5d908)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129666/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7292426159115828534==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic