[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason strin
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: 2016-12-17 18:02:58
Message-ID: 20161217180258.4515.37718 () mimi ! kde ! org
[Download RAW message or body]
--===============8399115890096856049==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 17, 2016, 4:53 p.m., Martin Klapetek wrote:
> > Just because it "looks annoying" doesn't mean it doesn't have its use.
> >
> > I'll do the git-blame-search for you: \
> > https://cgit.kde.org/knotifications.git/commit/?id=3f080d44af41d0158d7b5c51269449e78d5b128f
> >
>
> Anthony Fieroni wrote:
> I will correct GwenView too, about me this patch is at wrong place
This is not about Gwenview, this is about safe API that won't break with any other \
app actually not providing the reason.
Please leave this part alone.
> On Dec. 17, 2016, 4:53 p.m., Martin Klapetek wrote:
> > src/knotificationrestrictions.h, line 97
> > <https://git.reviewboard.kde.org/r/129666/diff/1/?file=487739#file487739line97>
> >
> > Why?
>
> Anthony Fieroni wrote:
> If new contructor is accepted, old one can be omitted.
This is a useful constructor, it doesn't need to be removed. Not all inhibitions \
*must* include a reason, iirc anyway.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129666/#review101483
-----------------------------------------------------------
On Dec. 17, 2016, 4:48 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129666/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2016, 4:48 p.m.)
>
>
> Review request for KDE Frameworks and Martin Klapetek.
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> "no_reason_specified" looks annoying reason
>
>
> Diffs
> -----
>
> src/knotificationrestrictions.h e9179ae
> src/knotificationrestrictions.cpp 5f5d908
>
> Diff: https://git.reviewboard.kde.org/r/129666/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============8399115890096856049==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129666/">https://git.reviewboard.kde.org/r/129666/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 17th, 2016, 4:53 p.m. CET, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Just because it "looks annoying" doesn't mean it \
doesn't have its use. </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'll do the git-blame-search for you: \
https://cgit.kde.org/knotifications.git/commit/?id=3f080d44af41d0158d7b5c51269449e78d5b128f</p></pre>
</blockquote>
<p>On December 17th, 2016, 6:17 p.m. CET, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
will correct GwenView too, about me this patch is at wrong place</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is not about Gwenview, this is about safe API that won't break with any other app \
actually not providing the reason.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Please leave this part \
alone.</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 17th, 2016, 4:53 p.m. CET, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129666/diff/1/?file=487739#file487739line97" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/knotificationrestrictions.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">97</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// </span><span class="cs">TODO</span><span class="c1"> KF6 \
remove</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Why?</p></pre> </blockquote>
<p>On December 17th, 2016, 6:17 p.m. CET, <b>Anthony Fieroni</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
new contructor is accepted, old one can be omitted.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This is a useful constructor, it doesn't need to be removed. Not all \
inhibitions <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">must</em> include a reason, iirc anyway.</p></pre> <br \
/>
<p>- Martin</p>
<br />
<p>On December 17th, 2016, 4:48 p.m. CET, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Martin Klapetek.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2016, 4:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">"no_reason_specified" looks annoying reason</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/knotificationrestrictions.h <span style="color: grey">(e9179ae)</span></li>
<li>src/knotificationrestrictions.cpp <span style="color: \
grey">(5f5d908)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129666/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8399115890096856049==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic