[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Review Request 129628: knewstuff - install missing headers
From:       José_Manuel_Santamaría_Lema <panfaust () gmail ! com>
Date:       2016-12-09 1:28:52
Message-ID: 20161209012852.13487.9753 () mimi ! kde ! org
[Download RAW message or body]

--===============1751965937662760013==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129628/
-----------------------------------------------------------

Review request for KDE Frameworks and Dan Leinir Turthra Jensen.


Repository: knewstuff


Description
-------

This patch installs a couple of missing headers:

* knewstuffcore_export.h - which is #include'd from many files in \
                /include/KF5/KNewStuff3/knscore/
* entry.h - this is #include'd from \
/usr/include/KF5/KNewStuff3/knscore/entryinternal.h as "../entry.h"

If the "entry.h" part of the patch is fine, maybe this commit should be reverted:
https://cgit.kde.org/knewstuff.git/commit/?id=7a644d7147edb816b69fa973630cea6aa72bc3ef



Diffs
-----

  src/CMakeLists.txt 79ef39b 
  src/core/CMakeLists.txt c2a1a24 

Diff: https://git.reviewboard.kde.org/r/129628/diff/


Testing
-------

I just ran a test from the kubuntu package meant to check that all the needed headers \
are available.


Thanks,

José Manuel  Santamaría Lema


--===============1751965937662760013==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129628/">https://git.reviewboard.kde.org/r/129628/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Dan Leinir Turthra Jensen.</div>
<div>By José Manuel  Santamaría Lema.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knewstuff
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch installs a couple of missing headers:</p> \
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">knewstuffcore_export.h - which is \
#include'd from many files in /include/KF5/KNewStuff3/knscore/</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">entry.h - this is #include'd from \
/usr/include/KF5/KNewStuff3/knscore/entryinternal.h as "../entry.h"</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If the "entry.h" part of the patch is fine, maybe this \
commit should be reverted: \
https://cgit.kde.org/knewstuff.git/commit/?id=7a644d7147edb816b69fa973630cea6aa72bc3ef</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I just ran a test from the kubuntu package meant to \
check that all the needed headers are available.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(79ef39b)</span></li>

 <li>src/core/CMakeLists.txt <span style="color: grey">(c2a1a24)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129628/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1751965937662760013==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic