From kde-frameworks-devel Fri Dec 09 01:28:52 2016 From: =?utf-8?q?Jos=C3=A9_Manuel_Santamar=C3=ADa_Lema?= Date: Fri, 09 Dec 2016 01:28:52 +0000 To: kde-frameworks-devel Subject: Review Request 129628: knewstuff - install missing headers Message-Id: <20161209012852.13487.9753 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=148124694531802 --===============1751965937662760013== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129628/ ----------------------------------------------------------- Review request for KDE Frameworks and Dan Leinir Turthra Jensen. Repository: knewstuff Description ------- This patch installs a couple of missing headers: * knewstuffcore_export.h - which is #include'd from many files in /include/KF5/KNewStuff3/knscore/ * entry.h - this is #include'd from /usr/include/KF5/KNewStuff3/knscore/entryinternal.h as "../entry.h" If the "entry.h" part of the patch is fine, maybe this commit should be reverted: https://cgit.kde.org/knewstuff.git/commit/?id=7a644d7147edb816b69fa973630cea6aa72bc3ef Diffs ----- src/CMakeLists.txt 79ef39b src/core/CMakeLists.txt c2a1a24 Diff: https://git.reviewboard.kde.org/r/129628/diff/ Testing ------- I just ran a test from the kubuntu package meant to check that all the needed headers are available. Thanks, José Manuel Santamaría Lema --===============1751965937662760013== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129628/

Review request for KDE Frameworks and Dan Leinir Turthra Jensen.
By José Manuel Santamaría Lema.
Repository: knewstuff

Description 

This patch installs a couple of missing headers:


    

  • knewstuffcore_export.h - which is #include'd from many files in /include/KF5/KNewStuff3/knscore/
    • 

  • entry.h - this is #include'd from /usr/include/KF5/KNewStuff3/knscore/entryinternal.h as "../entry.h"
    • 



If the "entry.h" part of the patch is fine, maybe this commit should be reverted:
https://cgit.kde.org/knewstuff.git/commit/?id=7a644d7147edb816b69fa973630cea6aa72bc3ef

Testing 

I just ran a test from the kubuntu package meant to check that all the needed headers are available.

Diffs

  • src/CMakeLists.txt (79ef39b)
  • src/core/CMakeLists.txt (c2a1a24)

View Diff
--===============1751965937662760013==--