[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 129197: Fix tests on FreeBSD
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2016-10-29 9:07:52
Message-ID: 20161029090752.5235.22927 () mimi ! kde ! org
[Download RAW message or body]

--===============7496137483440128292==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129197/#review100148
-----------------------------------------------------------




autotests/kptyprocesstest.cpp (line 123)
<https://git.reviewboard.kde.org/r/129197/#comment67266>

    just use QStandardPaths::findExecutable()
    
    anyway, that's for a separate commit.


- Oswald Buddenhagen


On Oct. 16, 2016, 11:44 a.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129197/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2016, 11:44 a.m.)
> 
> 
> Review request for KDE Frameworks, Adriaan de Groot, Tobias Berner, Oswald \
> Buddenhagen, and Martin Tobias Holmedahl Sandsmark. 
> 
> Repository: kpty
> 
> 
> Description
> -------
> 
> Apparently, KPtyDevice can't be operated on after KPtyProcess finishes. Tweak tests \
> accordingly, so they actually test things while the process is still running. 
> 
> Diffs
> -----
> 
> autotests/kptyprocesstest.cpp 8b0b5b0 
> 
> Diff: https://git.reviewboard.kde.org/r/129197/diff/
> 
> 
> Testing
> -------
> 
> make test on FreeBSD
> 
> 
> Thanks,
> 
> Gleb Popov
> 
> 


--===============7496137483440128292==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129197/">https://git.reviewboard.kde.org/r/129197/</a>
  </td>
    </tr>
   </table>
   <br />











<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/129197/diff/1/?file=482267#file482267line123" \
style="color: black; font-weight: bold; text-decoration: \
underline;">autotests/kptyprocesstest.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">123</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">p</span><span class="p">.</span><span class="n">setProgram</span><span \
class="p">(</span><span class="s">&quot;/bin/<span \
class="hl">bash</span>&quot;</span><span class="p">,</span> <span \
class="n">QStringList</span><span class="p">()</span> <span class="o">&lt;&lt;</span> \
<span class="s">&quot;-c&quot;</span> <span class="o">&lt;&lt;</span> <span \
class="s">&quot;read -s VAL; echo </span><span class="se">\&quot;</span><span \
class="s">1: $VAL</span><span class="se">\&quot;</span><span class="s">; echo \
</span><span class="se">\&quot;</span><span class="s">2: $VAL</span><span \
class="se">\&quot;</span><span class="s"> &gt;&amp;2&quot;</span><span \
class="p">);</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">123</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">    <span class="n">p</span><span \
class="p">.</span><span class="n">setProgram</span><span class="p">(</span><span \
class="s">&quot;/<span class="hl">usr/</span>bin/<span \
class="hl">env</span>&quot;</span><span class="p">,</span> <span \
class="n">QStringList</span><span class="p">()</span><span class="hl"> </span><span \
class="o"><span class="hl">&lt;&lt;</span></span><span class="hl"> </span><span \
class="s"><span class="hl">&quot;bash&quot;</span></span> <span \
class="o">&lt;&lt;</span> <span class="s">&quot;-c&quot;</span> <span \
class="o">&lt;&lt;</span> <span class="s">&quot;read -s VAL; echo </span><span \
class="se">\&quot;</span><span class="s">1: $VAL</span><span \
class="se">\&quot;</span><span class="s">; echo </span><span \
class="se">\&quot;</span><span class="s">2: $VAL</span><span \
class="se">\&quot;</span><span class="s"> &gt;&amp;2&quot;</span><span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just \
use QStandardPaths::findExecutable()</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">anyway, that's for a \
separate commit.</p></pre>  </div>
</div>
<br />



<p>- Oswald Buddenhagen</p>


<br />
<p>On October 16th, 2016, 11:44 a.m. UTC, Gleb Popov wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Adriaan de Groot, Tobias Berner, Oswald \
Buddenhagen, and Martin Tobias Holmedahl Sandsmark.</div> <div>By Gleb Popov.</div>


<p style="color: grey;"><i>Updated Oct. 16, 2016, 11:44 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kpty
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Apparently, KPtyDevice can't be operated on after \
KPtyProcess finishes. Tweak tests accordingly, so they actually test things while the \
process is still running.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make test on FreeBSD</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kptyprocesstest.cpp <span style="color: grey">(8b0b5b0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129197/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============7496137483440128292==--


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic