This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129197/

autotests/kptyprocesstest.cpp (Diff revision 1)
123	p.setProgram("/bin/bash", QStringList() << "-c" << "read -s VAL; echo \"1: $VAL\"; echo \"2: $VAL\" >&2");	123	p.setProgram("/usr/bin/env", QStringList() << "bash" << "-c" << "read -s VAL; echo \"1: $VAL\"; echo \"2: $VAL\" >&2");

autotests/kptyprocesstest.cpp (Diff revision 1)

123

    p.setProgram("/bin/bash", QStringList() << "-c" << "read -s VAL; echo \"1: $VAL\"; echo \"2: $VAL\" >&2");

123

    p.setProgram("/usr/bin/env", QStringList() << "bash" << "-c" << "read -s VAL; echo \"1: $VAL\"; echo \"2: $VAL\" >&2");

just use QStandardPaths::findExecutable()
anyway, that's for a separate commit.

- Oswald Buddenhagen

On October 16th, 2016, 11:44 a.m. UTC, Gleb Popov wrote:

Review request for KDE Frameworks, Adriaan de Groot, Tobias Berner, Oswald Buddenhagen, and Martin Tobias Holmedahl Sandsmark.

By Gleb Popov.

Updated Oct. 16, 2016, 11:44 a.m.

Repository: kpty

Description

Apparently, KPtyDevice can't be operated on after KPtyProcess finishes. Tweak tests accordingly, so they actually test things while the process is still running.

Testing

make test on FreeBSD

Diffs

autotests/kptyprocesstest.cpp (8b0b5b0)

View Diff