[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128888: Improve epub extractor, less segfaults
From: Boudhayan Gupta <bgupta () kde ! org>
Date: 2016-09-11 17:13:27
Message-ID: 20160911171327.10006.16436 () mimi ! kde ! org
[Download RAW message or body]
--===============2400049451032765667==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128888/#review99100
-----------------------------------------------------------
Ship it!
It looks sane enough to me. I'm going to assume you tested things and nothing obvious \
regressed, and give you the ship-it.
I'm also very interested in knowing how we have come about having a variable called \
`tit` ;-)
- Boudhayan Gupta
On Sept. 11, 2016, 10:32 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128888/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2016, 10:32 p.m.)
>
>
> Review request for KDE Frameworks, Boudhayan Gupta and Pinak Ahuja.
>
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> Improve epub extractor:
>
> 1) check for more nullpointers (e.g. data can be null for some fields, iterators, \
> ...) 2) actually close the epub file again at all
> 3) iterator seems to handle clink as stated in docs, fix double free
>
> e.g. see bug 361727
> could be the double freed clink in the last iterator
>
> https://bugs.kde.org/show_bug.cgi?id=361727
>
>
> Diffs
> -----
>
> src/extractors/epubextractor.cpp 88a4caa
>
> Diff: https://git.reviewboard.kde.org/r/128888/diff/
>
>
> Testing
> -------
>
> Unit test still works, no idea how to craft files broken enough to trigger the \
> faults
>
> Thanks,
>
> Christoph Cullmann
>
>
--===============2400049451032765667==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128888/">https://git.reviewboard.kde.org/r/128888/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
looks sane enough to me. I'm going to assume you tested things and nothing obvious \
regressed, and give you the ship-it.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm also very \
interested in knowing how we have come about having a variable called <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">tit</code> ;-)</p></pre> <br />
<p>- Boudhayan Gupta</p>
<br />
<p>On September 11th, 2016, 10:32 p.m. IST, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Boudhayan Gupta and Pinak Ahuja.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2016, 10:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Improve epub extractor:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) \
check for more nullpointers (e.g. data can be null for some fields, iterators, ...) \
2) actually close the epub file again at all 3) iterator seems to handle clink as \
stated in docs, fix double free</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">e.g. see bug 361727 \
could be the double freed clink in the last iterator</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://bugs.kde.org/show_bug.cgi?id=361727</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Unit test still works, no idea how to craft files \
broken enough to trigger the faults</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/extractors/epubextractor.cpp <span style="color: grey">(88a4caa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128888/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2400049451032765667==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic