[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128885: Increase size limit of baloo index for 64-bit machines
From: Christoph Cullmann <cullmann () kde ! org>
Date: 2016-09-11 16:59:11
Message-ID: 20160911165911.10006.41364 () mimi ! kde ! org
[Download RAW message or body]
--===============6577383129464175830==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 11, 2016, 4:50 p.m., Boudhayan Gupta wrote:
> > src/engine/database.cpp, line 107
> > <https://git.reviewboard.kde.org/r/128885/diff/1/?file=476712#file476712line107>
> >
> > This is clever, but I had to read it thrice to figure out what exactly it does. \
> > Maybe use this:
> > ```
> > ((sizeof(size_t) == 4) ? 1 : 256) * size_t(1024 * 1024 * 1024)
> > ```
> >
> > Seems more readable to me - the significant digits of the size followed by the \
> > multiplier.
> > If there's a performance or strictness issue I'm not seeing, please tell me.
>
> Boudhayan Gupta wrote:
> Err, could you also calculate the effective size in a const on the line above? \
> Sorry about the nitpick, I just want readability.
done + submitted
performance doesn't matter at all, this is done once and only arithmetics, who cares \
;=)
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128885/#review99096
-----------------------------------------------------------
On Sept. 11, 2016, 4:58 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128885/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2016, 4:58 p.m.)
>
>
> Review request for KDE Frameworks, Boudhayan Gupta, David Faure, and Pinak Ahuja.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Increase size limit of baloo index for 64-bit machines to avoid crashs after > 5GB \
> of index size. (Better would be additional out-of-space handling, but ATM baloo has \
> zero checks for that)
> The size limit for 32-bit is still 1GB, like before (there was a silent overflow \
> from 5GB to 1GB in the computation), people with large homes will still get random \
> segfaults on 32-bit.
> Patch based on patch from Hao Zhang, Bug 364475
> https://bugs.kde.org/show_bug.cgi?id=364475
>
>
> Diffs
> -----
>
> src/engine/database.cpp 89e2e03
> src/engine/databasesize.h aa180fb
> src/engine/transaction.cpp 0af20be
> src/tools/balooctl/statuscommand.cpp 73289c4
>
> Diff: https://git.reviewboard.kde.org/r/128885/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph Cullmann
>
>
--===============6577383129464175830==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128885/">https://git.reviewboard.kde.org/r/128885/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 11th, 2016, 4:50 p.m. UTC, \
<b>Boudhayan Gupta</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128885/diff/1/?file=476712#file476712line107" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/engine/database.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">106</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">mdb_env_set_mapsize</span><span class="p">(</span><span \
class="n">m_env</span><span class="p">,</span> <span class="kt">size_t</span><span \
class="p">(</span><span class="mi">1024</span><span class="p">)</span> <span \
class="o">*</span> <span class="kt">size_t</span><span class="p">(</span><span \
class="mi">1024</span><span class="p">)</span> <span class="o">*</span> <span \
class="kt">size_t</span><span class="p">(</span><span class="mi">1024</span><span \
class="p">)</span> <span class="o">*</span> <span class="kt">size_t</span><span \
class="p">((</span><span class="k">sizeof</span><span class="p">(</span><span \
class="kt">size_t</span><span class="p">)</span> <span class="o">==</span> <span \
class="mi">4</span><span class="p">)</span> <span class="o">?</span> <span \
class="mi">1</span> <span class="o">:</span> <span class="mi">256</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is clever, but I had to read it thrice to figure out what exactly it does. Maybe use \
this:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">((sizeof(size_t) == 4) ? 1 : 256) * \
size_t(1024 * 1024 * 1024) </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Seems more readable to me - the significant digits of \
the size followed by the multiplier.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">If there's a \
performance or strictness issue I'm not seeing, please tell me.</p></pre> \
</blockquote>
<p>On September 11th, 2016, 4:53 p.m. UTC, <b>Boudhayan Gupta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Err, \
could you also calculate the effective size in a const on the line above? Sorry about \
the nitpick, I just want readability.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">done + submitted performance doesn't matter at all, this is done once and \
only arithmetics, who cares ;=)</p></pre> <br />
<p>- Christoph</p>
<br />
<p>On September 11th, 2016, 4:58 p.m. UTC, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Boudhayan Gupta, David Faure, and Pinak \
Ahuja.</div> <div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2016, 4:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Increase size limit of baloo index for 64-bit machines \
to avoid crashs after > 5GB of index size. (Better would be additional \
out-of-space handling, but ATM baloo has zero checks for that)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
size limit for 32-bit is still 1GB, like before (there was a silent overflow from 5GB \
to 1GB in the computation), people with large homes will still get random segfaults \
on 32-bit.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Patch based on patch from Hao Zhang, Bug 364475 \
https://bugs.kde.org/show_bug.cgi?id=364475</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/database.cpp <span style="color: grey">(89e2e03)</span></li>
<li>src/engine/databasesize.h <span style="color: grey">(aa180fb)</span></li>
<li>src/engine/transaction.cpp <span style="color: grey">(0af20be)</span></li>
<li>src/tools/balooctl/statuscommand.cpp <span style="color: \
grey">(73289c4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128885/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6577383129464175830==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic