[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 128887: ctime/mtime => 0 (which is perfectly OK) => baloo dead
From: Christoph Cullmann <cullmann () kde ! org>
Date: 2016-09-11 16:52:32
Message-ID: 20160911165232.10006.55515 () mimi ! kde ! org
[Download RAW message or body]
--===============4690801763275358542==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 11, 2016, 3:05 p.m., Sune Vuorela wrote:
> > Looks good to me. I would though appreciate a unit test if ever possible. It \
> > would be an easy bug to reintroduce.
>
> Christoph Cullmann wrote:
> I can try to create one ;=)
Added unit test + pushed
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128887/#review99092
-----------------------------------------------------------
On Sept. 11, 2016, 4:52 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128887/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2016, 4:52 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Fix that baloo is instant killed by any file with timestamp 0. (which is OK and can \
> easily happen after unpacking some zip/tar/..)
> Bug 355238
> https://bugs.kde.org/show_bug.cgi?id=355238
>
>
> Diffs
> -----
>
> src/engine/documenttimedb.cpp aa0925a
> src/engine/writetransaction.cpp 9ad7520
>
> Diff: https://git.reviewboard.kde.org/r/128887/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph Cullmann
>
>
--===============4690801763275358542==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128887/">https://git.reviewboard.kde.org/r/128887/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 11th, 2016, 3:05 p.m. UTC, <b>Sune \
Vuorela</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Looks good to me. I would though appreciate a unit \
test if ever possible. It would be an easy bug to reintroduce.</p></pre> \
</blockquote>
<p>On September 11th, 2016, 4:02 p.m. UTC, <b>Christoph Cullmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can \
try to create one ;=)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added \
unit test + pushed</p></pre> <br />
<p>- Christoph</p>
<br />
<p>On September 11th, 2016, 4:52 p.m. UTC, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2016, 4:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix that baloo is instant killed by any file with \
timestamp 0. (which is OK and can easily happen after unpacking some zip/tar/..)</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Bug 355238 \
https://bugs.kde.org/show_bug.cgi?id=355238</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/engine/documenttimedb.cpp <span style="color: grey">(aa0925a)</span></li>
<li>src/engine/writetransaction.cpp <span style="color: grey">(9ad7520)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128887/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4690801763275358542==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic