From kde-frameworks-devel Sun Sep 11 16:52:32 2016 From: Christoph Cullmann Date: Sun, 11 Sep 2016 16:52:32 +0000 To: kde-frameworks-devel Subject: Re: Review Request 128887: ctime/mtime => 0 (which is perfectly OK) => baloo dead Message-Id: <20160911165232.10006.55515 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=147361275732354 --===============4690801763275358542== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 11, 2016, 3:05 p.m., Sune Vuorela wrote: > > Looks good to me. I would though appreciate a unit test if ever possible. It would be an easy bug to reintroduce. > > Christoph Cullmann wrote: > I can try to create one ;=) Added unit test + pushed - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128887/#review99092 ----------------------------------------------------------- On Sept. 11, 2016, 4:52 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128887/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2016, 4:52 p.m.) > > > Review request for KDE Frameworks. > > > Repository: baloo > > > Description > ------- > > Fix that baloo is instant killed by any file with timestamp 0. (which is OK and can easily happen after unpacking some zip/tar/..) > > Bug 355238 > https://bugs.kde.org/show_bug.cgi?id=355238 > > > Diffs > ----- > > src/engine/documenttimedb.cpp aa0925a > src/engine/writetransaction.cpp 9ad7520 > > Diff: https://git.reviewboard.kde.org/r/128887/diff/ > > > Testing > ------- > > > Thanks, > > Christoph Cullmann > > --===============4690801763275358542== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128887/

On September 11th, 2016, 3:05 p.m. UTC, Sune Vuorela wrote:
Looks good to me. I would though appreciate a unit test if ever possible.  It would be an easy bug to reintroduce.
On September 11th, 2016, 4:02 p.m. UTC, Christoph Cullmann wrote:
I can try to create one ;=)

Added unit test + pushed

- Christoph

On September 11th, 2016, 4:52 p.m. UTC, Christoph Cullmann wrote:

Review request for KDE Frameworks.

By Christoph Cullmann.

Updated Sept. 11, 2016, 4:52 p.m.

Repository: baloo

Description

Fix that baloo is instant killed by any file with timestamp 0. (which is OK and can easily happen after unpacking some zip/tar/..)

Bug 355238 https://bugs.kde.org/show_bug.cgi?id=355238

Diffs

src/engine/documenttimedb.cpp (aa0925a)
src/engine/writetransaction.cpp (9ad7520)

View Diff

--===============4690801763275358542==--