'Re: Review Request 128085: Fix check that CPU is a valid CPU'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128085: Fix check that CPU is a valid CPU
From:       Rohan Garg <rohangarg () kubuntu ! org>
Date:       2016-06-06 21:33:43
Message-ID: 20160606213343.3239.50619 () mimi ! kde ! org
[Download RAW message or body]

--===============8960490190054632844==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128085/#review96238
-----------------------------------------------------------

Hi
Could we get a shipit on these? I'd really appreciate it if we could have these in \
Frameworks 5.23

- Rohan Garg

On June 3, 2016, 5:45 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128085/
> -----------------------------------------------------------
> 
> (Updated June 3, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> We have a check that an devices/system/cpu/cpuN entry contains a
> processor and not just an empty socket, however it relies on somewhat
> outdated /sys files.
> 
> cpuN/cpufreq isn't guaranteed to exist as for some systems (my AMD
> processor at least).
> 
> The docs in the linux kernel imply topology/core_id should always exist,
> and should still work as a valid check that we have a populated CPU
> socket.
> 
> 
> Diffs
> -----
> 
> src/solid/devices/backends/udev/udevmanager.cpp \
> 3f3a671798e84e6d577df7c3b9b80150ac4d01fc  
> Diff: https://git.reviewboard.kde.org/r/128085/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============8960490190054632844==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128085/">https://git.reviewboard.kde.org/r/128085/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Could we get a shipit on these? I'd really appreciate it if we could have these in \
Frameworks 5.23</p></pre>  <br />

<p>- Rohan Garg</p>

<br />
<p>On June 3rd, 2016, 5:45 p.m. IST, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Solid.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated June 3, 2016, 5:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We have a check that an devices/system/cpu/cpuN entry contains a \
processor and not just an empty socket, however it relies on somewhat outdated /sys \
files.

cpuN/cpufreq isn&#39;t guaranteed to exist as for some systems (my AMD
processor at least).

The docs in the linux kernel imply topology/core_id should always exist,
and should still work as a valid check that we have a populated CPU
socket.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/solid/devices/backends/udev/udevmanager.cpp <span style="color: \
grey">(3f3a671798e84e6d577df7c3b9b80150ac4d01fc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128085/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8960490190054632844==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 