'Re: Review Request 128084: Handle reading /proc/cpuinfo for Arm processors'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 128084: Handle reading /proc/cpuinfo for Arm processors
From:       Rohan Garg <rohangarg () kubuntu ! org>
Date:       2016-06-06 21:33:32
Message-ID: 20160606213332.3239.71613 () mimi ! kde ! org
[Download RAW message or body]

--===============4836010817478936123==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128084/#review96237
-----------------------------------------------------------

Hi
Could we get a shipit on these? I'd really appreciate it if we could have these in \
Frameworks 5.23

- Rohan Garg

On June 3, 2016, 5:45 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128084/
> -----------------------------------------------------------
> 
> (Updated June 3, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Solid.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> The /proc/cpuinfo format is wildly different between architectures, our
> current method for scraping data only works on x86.
> 
> This patch moves all parsing logic into cpuinfo.cpp and adds a fallback
> search that works for arm and arm64 architectures.
> 
> ----
> https://github.com/torvalds/linux/blob/master/arch/x86/kernel/cpu/proc.c#L55
> 
> https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L104
> 
> 
> Diffs
> -----
> 
> src/solid/devices/backends/udev/cpuinfo.h e8d5dda729535e767b4640f41a01f4d0e27e6542 
> src/solid/devices/backends/udev/cpuinfo.cpp \
> ecaad58ceee34d46343b67015c03d9a3de87ee72  \
> src/solid/devices/backends/udev/udevdevice.cpp \
> 9fb5e092679cd3c6860b2055cf3dedb915addfda  \
> src/solid/devices/backends/udev/udevprocessor.cpp \
> 80d14f5b40b4478a32d7c113747fe9da50e54b6f  
> Diff: https://git.reviewboard.kde.org/r/128084/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============4836010817478936123==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128084/">https://git.reviewboard.kde.org/r/128084/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Could we get a shipit on these? I'd really appreciate it if we could have these in \
Frameworks 5.23</p></pre>  <br />

<p>- Rohan Garg</p>

<br />
<p>On June 3rd, 2016, 5:45 p.m. IST, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Solid.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated June 3, 2016, 5:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The /proc/cpuinfo format is wildly different between \
architectures, our current method for scraping data only works on x86.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch moves all parsing logic into cpuinfo.cpp \
and adds a fallback search that works for arm and arm64 architectures.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">---- \
https://github.com/torvalds/linux/blob/master/arch/x86/kernel/cpu/proc.c#L55</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L104</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/solid/devices/backends/udev/cpuinfo.h <span style="color: \
grey">(e8d5dda729535e767b4640f41a01f4d0e27e6542)</span></li>

 <li>src/solid/devices/backends/udev/cpuinfo.cpp <span style="color: \
grey">(ecaad58ceee34d46343b67015c03d9a3de87ee72)</span></li>

 <li>src/solid/devices/backends/udev/udevdevice.cpp <span style="color: \
grey">(9fb5e092679cd3c6860b2055cf3dedb915addfda)</span></li>

 <li>src/solid/devices/backends/udev/udevprocessor.cpp <span style="color: \
grey">(80d14f5b40b4478a32d7c113747fe9da50e54b6f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128084/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4836010817478936123==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 