'Re: Review Request 127666: kconfig and kurlrequester friendship: store local paths in string-typed i'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 127666: kconfig and kurlrequester friendship: store local paths in string-typed i
From:       Nick Shaforostoff <shafff () ukr ! net>
Date:       2016-04-30 23:45:05
Message-ID: 20160430234505.11646.99148 () mimi ! kde ! org
[Download RAW message or body]

--===============5694226338676244485==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127666/
-----------------------------------------------------------

(Updated April 30, 2016, 11:45 p.m.)

Status
------

This change has been discarded.

Review request for KDE Frameworks and Matthew Dawson.

Repository: kconfig

Description
-------

in ktorrent kcfg_*-names kurlrequester is used to edit a string-typed setting (it may \
contain only local paths). this patch makes sure that no file:// prefix is added on \
setting change by adding a special check for the case when qvariant contains qurl and \
converting it appropriately

Diffs
-----

  src/core/kcoreconfigskeleton.cpp 293387b 

Diff: https://git.reviewboard.kde.org/r/127666/diff/

Testing
-------

ktorrent now displays local paths in settings dialog without file:// prefix

Thanks,

Nick Shaforostoff

--===============5694226338676244485==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127666/">https://git.reviewboard.kde.org/r/127666/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Matthew Dawson.</div>
<div>By Nick Shaforostoff.</div>

<p style="color: grey;"><i>Updated April 30, 2016, 11:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">in ktorrent kcfg_*-names kurlrequester is used to edit a string-typed \
setting (it may contain only local paths). this patch makes sure that no file:// \
prefix is added on setting change by adding a special check for the case when \
qvariant contains qurl and converting it appropriately</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ktorrent now displays local paths in settings dialog \
without file:// prefix</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/kcoreconfigskeleton.cpp <span style="color: grey">(293387b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127666/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5694226338676244485==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 