From kde-frameworks-devel Sat Apr 30 23:45:05 2016 From: Nick Shaforostoff Date: Sat, 30 Apr 2016 23:45:05 +0000 To: kde-frameworks-devel Subject: Re: Review Request 127666: kconfig and kurlrequester friendship: store local paths in string-typed i Message-Id: <20160430234505.11646.99148 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=146205993523301 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5256026901593770212==" --===============5256026901593770212== Content-Type: multipart/alternative; boundary="===============5694226338676244485==" --===============5694226338676244485== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127666/ ----------------------------------------------------------- (Updated April 30, 2016, 11:45 p.m.) Status ------ This change has been discarded. Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description ------- in ktorrent kcfg_*-names kurlrequester is used to edit a string-typed setting (it may contain only local paths). this patch makes sure that no file:// prefix is added on setting change by adding a special check for the case when qvariant contains qurl and converting it appropriately Diffs ----- src/core/kcoreconfigskeleton.cpp 293387b Diff: https://git.reviewboard.kde.org/r/127666/diff/ Testing ------- ktorrent now displays local paths in settings dialog without file:// prefix Thanks, Nick Shaforostoff --===============5694226338676244485== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127666/

This change has been discarded.

Review request for KDE Frameworks and Matthew Dawson.

By Nick Shaforostoff.

Updated April 30, 2016, 11:45 p.m.

Repository: kconfig

Description

in ktorrent kcfg_*-names kurlrequester is used to edit a string-typed setting (it may contain only local paths).
this patch makes sure that no file:// prefix is added on setting change by adding a special check for the case when qvariant contains qurl and converting it appropriately

Testing

ktorrent now displays local paths in settings dialog without file:// prefix

Diffs

src/core/kcoreconfigskeleton.cpp (293387b)

View Diff

--===============5694226338676244485==-- --===============5256026901593770212== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============5256026901593770212==--