[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request 126403: Get rid of QApplication dependency
From: "David Faure" <faure () kde ! org>
Date: 2016-01-10 23:33:52
Message-ID: 20160110233352.23702.75318 () mimi ! kde ! org
[Download RAW message or body]
--===============6053962990295431033==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126403/#review90863
-----------------------------------------------------------
OK, I was mentionning the commit log because the one in reviewboard says "still \
UNTESTED" ;)
Anyhow, looks good to me now, but I'd rather that it gets reviewed by e.g. Martin \
Graesslin too.
src/platforms/xcb/kwindowsystem.cpp (line 79)
<https://git.reviewboard.kde.org/r/126403/#comment62080>
this ';' seems unnecessary and weird, it's the end of an if() block.
- David Faure
On Jan. 10, 2016, 9:58 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126403/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2016, 9:58 p.m.)
>
>
> Review request for KDE Frameworks, kwin and Albert Astals Cid.
>
>
> Bugs: 354811
> https://bugs.kde.org/show_bug.cgi?id=354811
>
>
> Repository: kwindowsystem
>
>
> Description
> -------
>
> summarized, alternative to https://git.reviewboard.kde.org/r/126397/
>
> NOTICE: this compiles but is otherwise *completely* untested!
>
>
> Diffs
> -----
>
> src/platforms/xcb/kwindowsystem.cpp 9d28704
>
> Diff: https://git.reviewboard.kde.org/r/126403/diff/
>
>
> Testing
> -------
>
> Albert performed a successful test on the bug.
>
>
> Thanks,
>
> Thomas Lübking
>
>
--===============6053962990295431033==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126403/">https://git.reviewboard.kde.org/r/126403/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, I \
was mentionning the commit log because the one in reviewboard says "still UNTESTED" \
;)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Anyhow, looks good to me now, but I'd rather that it \
gets reviewed by e.g. Martin Graesslin too.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126403/diff/3/?file=430337#file430337line80" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/platforms/xcb/kwindowsystem.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">79</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">};</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
';' seems unnecessary and weird, it's the end of an if() block.</p></pre> </div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On January 10th, 2016, 9:58 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, kwin and Albert Astals Cid.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2016, 9:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=354811">354811</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">summarized, alternative to \
https://git.reviewboard.kde.org/r/126397/</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">NOTICE: this compiles \
but is otherwise <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">completely</em> untested!</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Albert performed a successful test on the \
bug.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platforms/xcb/kwindowsystem.cpp <span style="color: \
grey">(9d28704)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126403/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6053962990295431033==--
[Attachment #3 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic