From kwin Sun Jan 10 23:33:52 2016 From: "David Faure" Date: Sun, 10 Jan 2016 23:33:52 +0000 To: kwin Subject: Re: Review Request 126403: Get rid of QApplication dependency Message-Id: <20160110233352.23702.75318 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kwin&m=145246886923793 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0242033807830321666==" --===============0242033807830321666== Content-Type: multipart/alternative; boundary="===============6053962990295431033==" --===============6053962990295431033== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90863 ----------------------------------------------------------- OK, I was mentionning the commit log because the one in reviewboard says "still UNTESTED" ;) Anyhow, looks good to me now, but I'd rather that it gets reviewed by e.g. Martin Graesslin too. src/platforms/xcb/kwindowsystem.cpp (line 79) this ';' seems unnecessary and weird, it's the end of an if() block. - David Faure On Jan. 10, 2016, 9:58 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126403/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2016, 9:58 p.m.) > > > Review request for KDE Frameworks, kwin and Albert Astals Cid. > > > Bugs: 354811 > https://bugs.kde.org/show_bug.cgi?id=354811 > > > Repository: kwindowsystem > > > Description > ------- > > summarized, alternative to https://git.reviewboard.kde.org/r/126397/ > > NOTICE: this compiles but is otherwise *completely* untested! > > > Diffs > ----- > > src/platforms/xcb/kwindowsystem.cpp 9d28704 > > Diff: https://git.reviewboard.kde.org/r/126403/diff/ > > > Testing > ------- > > Albert performed a successful test on the bug. > > > Thanks, > > Thomas Lübking > > --===============6053962990295431033== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/

OK, I was mentionning the commit log because the one in reviewboard says "still UNTESTED" ;)

Anyhow, looks good to me now, but I'd rather that it gets reviewed by e.g. Martin Graesslin too.

src/platforms/xcb/kwindowsystem.cpp (Diff revision 3)
		79	};

this ';' seems unnecessary and weird, it's the end of an if() block.

- David Faure

On January 10th, 2016, 9:58 p.m. UTC, Thomas Lübking wrote:

Review request for KDE Frameworks, kwin and Albert Astals Cid.

By Thomas Lübking.

Updated Jan. 10, 2016, 9:58 p.m.

Bugs: 354811

Repository: kwindowsystem

Description

summarized, alternative to https://git.reviewboard.kde.org/r/126397/

NOTICE: this compiles but is otherwise completely untested!

Testing

Albert performed a successful test on the bug.

Diffs

src/platforms/xcb/kwindowsystem.cpp (9d28704)

View Diff

--===============6053962990295431033==-- --===============0242033807830321666== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3dpbiBtYWls aW5nIGxpc3QKa3dpbkBrZGUub3JnCmh0dHBzOi8vbWFpbC5rZGUub3JnL21haWxtYW4vbGlzdGlu Zm8va3dpbgo= --===============0242033807830321666==--