[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126681: Duplicate the file descriptor while opening
From: "David Faure" <faure () kde ! org>
Date: 2016-01-10 9:59:30
Message-ID: 20160110095930.23702.29837 () mimi ! kde ! org
[Download RAW message or body]
--===============4021340560877916455==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 9, 2016, 1:28 p.m., Kai Uwe Broulik wrote:
> > I think we should do a re-spin of KF 5.18?
>
> Luigi Toscano wrote:
> I think it was already done: \
> https://mail.kde.org/pipermail/release-team/2016-January/009263.html
> Kai Uwe Broulik wrote:
> ok, I was just wondering because it wasn't mentioned in the changelog :)
>
> David Faure wrote:
> A changelog is only a summary of the changes that impact the users of the \
> framework, not the full git log.
> When a release contains a change, and then a "oops" fix for the change, I remove \
> the oops commit, it's irrelevant to the users of the release, who have never hit \
> the temporary problem introduced by the first version of the change.
> To know if a commit is in a release, better trust the git tag.
"I remove the oops commit" ... from the changelog, of course.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126681/#review90814
-----------------------------------------------------------
On Jan. 8, 2016, 9:41 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126681/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 9:41 p.m.)
>
>
> Review request for KDE Frameworks and Christoph Cullmann.
>
>
> Repository: kwallet
>
>
> Description
> -------
>
> Closing the fd results in kwallet being in a blocked state
> with all requests to it being timed out.
>
> This fixes the issue.
>
> Thanks to Christoph Cullmann spotting the issue.
>
>
> Diffs
> -----
>
> src/runtime/kwalletd/main.cpp a48de08
>
> Diff: https://git.reviewboard.kde.org/r/126681/diff/
>
>
> Testing
> -------
>
> KWallet no longer times out after login.
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============4021340560877916455==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126681/">https://git.reviewboard.kde.org/r/126681/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 9th, 2016, 1:28 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I think we should do a re-spin of KF 5.18?</p></pre> \
</blockquote>
<p>On January 9th, 2016, 2:23 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think it was already done: \
https://mail.kde.org/pipermail/release-team/2016-January/009263.html</p></pre> \
</blockquote>
<p>On January 9th, 2016, 4:08 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ok, I \
was just wondering because it wasn't mentioned in the changelog :)</p></pre> \
</blockquote>
<p>On January 10th, 2016, 9:58 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A \
changelog is only a summary of the changes that impact the users of the framework, \
not the full git log.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">When a release contains a change, and \
then a "oops" fix for the change, I remove the oops commit, it's irrelevant to the \
users of the release, who have never hit the temporary problem introduced by the \
first version of the change.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">To know if a commit is in a release, \
better trust the git tag.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"I \
remove the oops commit" ... from the changelog, of course.</p></pre> <br />
<p>- David</p>
<br />
<p>On January 8th, 2016, 9:41 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Christoph Cullmann.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2016, 9:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Closing the fd results in kwallet being in a blocked \
state with all requests to it being timed out.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes the issue.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks to Christoph Cullmann spotting the issue.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KWallet no longer times out after login.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/runtime/kwalletd/main.cpp <span style="color: grey">(a48de08)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126681/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4021340560877916455==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic