From kde-frameworks-devel Sun Jan 10 09:59:30 2016 From: "David Faure" Date: Sun, 10 Jan 2016 09:59:30 +0000 To: kde-frameworks-devel Subject: Re: Review Request 126681: Duplicate the file descriptor while opening Message-Id: <20160110095930.23702.29837 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=145241999011990 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1710560144875331406==" --===============1710560144875331406== Content-Type: multipart/alternative; boundary="===============4021340560877916455==" --===============4021340560877916455== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 9, 2016, 1:28 p.m., Kai Uwe Broulik wrote: > > I think we should do a re-spin of KF 5.18? > > Luigi Toscano wrote: > I think it was already done: https://mail.kde.org/pipermail/release-team/2016-January/009263.html > > Kai Uwe Broulik wrote: > ok, I was just wondering because it wasn't mentioned in the changelog :) > > David Faure wrote: > A changelog is only a summary of the changes that impact the users of the framework, not the full git log. > > When a release contains a change, and then a "oops" fix for the change, I remove the oops commit, it's irrelevant to the users of the release, who have never hit the temporary problem introduced by the first version of the change. > > To know if a commit is in a release, better trust the git tag. "I remove the oops commit" ... from the changelog, of course. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126681/#review90814 ----------------------------------------------------------- On Jan. 8, 2016, 9:41 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126681/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 9:41 p.m.) > > > Review request for KDE Frameworks and Christoph Cullmann. > > > Repository: kwallet > > > Description > ------- > > Closing the fd results in kwallet being in a blocked state > with all requests to it being timed out. > > This fixes the issue. > > Thanks to Christoph Cullmann spotting the issue. > > > Diffs > ----- > > src/runtime/kwalletd/main.cpp a48de08 > > Diff: https://git.reviewboard.kde.org/r/126681/diff/ > > > Testing > ------- > > KWallet no longer times out after login. > > > Thanks, > > Martin Klapetek > > --===============4021340560877916455== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126681/

On January 9th, 2016, 1:28 p.m. UTC, Kai Uwe Broulik wrote:

I think we should do a re-spin of KF 5.18?

On January 9th, 2016, 2:23 p.m. UTC, Luigi Toscano wrote:

I think it was already done: https://mail.kde.org/pipermail/release-team/2016-January/009263.html

On January 9th, 2016, 4:08 p.m. UTC, Kai Uwe Broulik wrote:

ok, I was just wondering because it wasn't mentioned in the changelog :)

On January 10th, 2016, 9:58 a.m. UTC, David Faure wrote:

A changelog is only a summary of the changes that impact the users of the framework, not the full git log.


When a release contains a change, and then a "oops" fix for the change, I remove the oops commit, it's irrelevant to the users of the release, who have never hit the temporary problem introduced by the first version of the change.


To know if a commit is in a release, better trust the git tag.
"I remove the oops commit" ... from the changelog, of course.

- David


On January 8th, 2016, 9:41 p.m. UTC, Martin Klapetek wrote:

Review request for KDE Frameworks and Christoph Cullmann.
By Martin Klapetek.

Updated Jan. 8, 2016, 9:41 p.m.

Repository: kwallet

Description 

Closing the fd results in kwallet being in a blocked state
with all requests to it being timed out.


This fixes the issue.


Thanks to Christoph Cullmann spotting the issue.

Testing 

KWallet no longer times out after login.

Diffs

  • src/runtime/kwalletd/main.cpp (a48de08)

View Diff
--===============4021340560877916455==-- --===============1710560144875331406== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============1710560144875331406==--