'Re: Review Request 126674: Add a thumbnailer for kra/ora images'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126674: Add a thumbnailer for kra/ora images
From:       "David Faure" <faure () kde ! org>
Date:       2016-01-10 9:49:58
Message-ID: 20160110094958.23702.94969 () mimi ! kde ! org
[Download RAW message or body]

--===============4514417905659431179==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126674/#review90833
-----------------------------------------------------------

Ship it!

Code looks good, only found some coding style issues

thumbnail/CMakeLists.txt (line 224)
<https://git.reviewboard.kde.org/r/126674/#comment62068>

    trailing space

thumbnail/kritacreator.h (line 24)
<https://git.reviewboard.kde.org/r/126674/#comment62067>

    unused

thumbnail/kritacreator.h (line 37)
<https://git.reviewboard.kde.org/r/126674/#comment62066>

    Q_DECL_OVERRIDE rather than virtual, on both lines

thumbnail/kritacreator.cpp (line 52)
<https://git.reviewboard.kde.org/r/126674/#comment62063>

    On two separate lines please (preferrably with curly braces, like the rest of \
this file, to match the KF5 coding style)

thumbnail/kritacreator.cpp (line 84)
<https://git.reviewboard.kde.org/r/126674/#comment62065>

    indentation looks wrong

thumbnail/kritacreator.cpp (line 86)
<https://git.reviewboard.kde.org/r/126674/#comment62064>

    join with } on previous line

    (or just run astyle-kdelibs from kde-dev-scripts)

- David Faure

On Jan. 8, 2016, 8:38 a.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126674/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 8:38 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> KRA and ORA files are mostly the same internally, a zip container with small PNG \
> thumbnail. I would like to move the thumbnailer from krita to kio-extras since it \
> no longer depends on any Krita code, and people who haven't got Krita installed \
> might still want to see krita or openraster thumbnails in Dolphin. The actual \
> author of the code is Frinring. 
> 
> Diffs
> -----
> 
> thumbnail/CMakeLists.txt 4addb26 
> thumbnail/kraorathumbnail.desktop PRE-CREATION 
> thumbnail/kritacreator.h PRE-CREATION 
> thumbnail/kritacreator.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126674/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
> 

--===============4514417905659431179==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126674/">https://git.reviewboard.kde.org/r/126674/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Code \
looks good, only found some coding style issues</p></pre>  <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126674/diff/1/?file=429101#file429101line224" \
style="color: black; font-weight: bold; text-decoration: \
underline;">thumbnail/CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">224</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">set</span><span class="p">(</span><span \
class="s">kritathumbnail_SRCS</span> <span class="s">kritacreator.cpp</span><span \
class="p">)</span><span class="ew"> </span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">trailing space</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126674/diff/1/?file=429103#file429103line24" \
style="color: black; font-weight: bold; text-decoration: \
underline;">thumbnail/kritacreator.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">24</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include &lt;QIODevice&gt;</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">unused</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126674/diff/1/?file=429103#file429103line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">thumbnail/kritacreator.h</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">37</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">virtual</span> <span class="kt">bool</span> <span \
class="nf">create</span><span class="p">(</span><span class="k">const</span> <span \
class="n">QString</span> <span class="o">&amp;</span><span class="n">path</span><span \
class="p">,</span> <span class="kt">int</span> <span class="n">width</span><span \
class="p">,</span> <span class="kt">int</span> <span class="n">height</span><span \
class="p">,</span> <span class="n">QImage</span> <span class="o">&amp;</span><span \
class="n">image</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Q_DECL_OVERRIDE rather than virtual, on both lines</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126674/diff/1/?file=429104#file429104line52" \
style="color: black; font-weight: bold; text-decoration: \
underline;">thumbnail/kritacreator.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">52</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">zip</span><span class="p">.</span><span class="n">open</span><span \
class="p">(</span><span class="n">QIODevice</span><span class="o">::</span><span \
class="n">ReadOnly</span><span class="p">))</span> <span class="k">return</span> \
<span class="nb">false</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On \
two separate lines please (preferrably with curly braces, like the rest of this file, \
to match the KF5 coding style)</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126674/diff/1/?file=429104#file429104line84" \
style="color: black; font-weight: bold; text-decoration: \
underline;">thumbnail/kritacreator.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">84</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">Qt</span><span class="o">::</span><span \
class="n">KeepAspectRatio</span><span class="p">,</span> <span \
class="n">Qt</span><span class="o">::</span><span \
class="n">SmoothTransformation</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">indentation looks wrong</p></pre>  </div>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126674/diff/1/?file=429104#file429104line86" \
style="color: black; font-weight: bold; text-decoration: \
underline;">thumbnail/kritacreator.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">86</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">else</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">join \
with } on previous line</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">(or just run astyle-kdelibs from \
kde-dev-scripts)</p></pre>  </div>
</div>
<br />

<p>- David Faure</p>

<br />
<p>On January 8th, 2016, 8:38 a.m. UTC, Boudewijn Rempt wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Boudewijn Rempt.</div>

<p style="color: grey;"><i>Updated Jan. 8, 2016, 8:38 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KRA and ORA files are mostly the same internally, a \
zip container with small PNG thumbnail. I would like to move the thumbnailer from \
krita to kio-extras since it no longer depends on any Krita code, and people who \
haven't got Krita installed might still want to see krita or openraster thumbnails in \
Dolphin. The actual author of the code is Frinring.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>thumbnail/CMakeLists.txt <span style="color: grey">(4addb26)</span></li>

 <li>thumbnail/kraorathumbnail.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>thumbnail/kritacreator.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>thumbnail/kritacreator.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126674/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4514417905659431179==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 