--===============1635655686559228781== Content-Type: multipart/alternative; boundary="===============4514417905659431179==" --===============4514417905659431179== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126674/#review90833 ----------------------------------------------------------- Ship it! Code looks good, only found some coding style issues thumbnail/CMakeLists.txt (line 224) trailing space thumbnail/kritacreator.h (line 24) unused thumbnail/kritacreator.h (line 37) Q_DECL_OVERRIDE rather than virtual, on both lines thumbnail/kritacreator.cpp (line 52) On two separate lines please (preferrably with curly braces, like the rest of this file, to match the KF5 coding style) thumbnail/kritacreator.cpp (line 84) indentation looks wrong thumbnail/kritacreator.cpp (line 86) join with } on previous line (or just run astyle-kdelibs from kde-dev-scripts) - David Faure On Jan. 8, 2016, 8:38 a.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126674/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 8:38 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio-extras > > > Description > ------- > > KRA and ORA files are mostly the same internally, a zip container with small PNG thumbnail. I would like to move the thumbnailer from krita to kio-extras since it no longer depends on any Krita code, and people who haven't got Krita installed might still want to see krita or openraster thumbnails in Dolphin. The actual author of the code is Frinring. > > > Diffs > ----- > > thumbnail/CMakeLists.txt 4addb26 > thumbnail/kraorathumbnail.desktop PRE-CREATION > thumbnail/kritacreator.h PRE-CREATION > thumbnail/kritacreator.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126674/diff/ > > > Testing > ------- > > > Thanks, > > Boudewijn Rempt > > --===============4514417905659431179== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126674/

Ship it!

Code looks good, only found some coding style issues

thumbnail/CMakeLists.txt (Diff revision 1) 

    224
    
set(kritathumbnail_SRCS kritacreator.cpp) 

  


 




 


  
trailing space

 













 
  

   
    thumbnail/kritacreator.h
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    24
    
#include <QIODevice>

  


 




 


  
unused

 













 
  

   
    thumbnail/kritacreator.h
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    37
    
    virtual bool create(const QString &path, int width, int height, QImage &image);

  


 




 


  
Q_DECL_OVERRIDE rather than virtual, on both lines

 













 
  

   
    thumbnail/kritacreator.cpp
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    52
    
    if (!zip.open(QIODevice::ReadOnly)) return false;

  


 




 


  
On two separate lines please (preferrably with curly braces, like the rest of this file, to match the KF5 coding style)

 













 
  

   
    thumbnail/kritacreator.cpp
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    84
    
                                           Qt::KeepAspectRatio, Qt::SmoothTransformation);

  


 




 


  
indentation looks wrong

 













 
  

   
    thumbnail/kritacreator.cpp
    

     (Diff revision 1)

    
   
  

 



 
 

 

  

    
    

    86
    
        else {

  


 




 


  
join with } on previous line


(or just run astyle-kdelibs from kde-dev-scripts)

 









- David Faure






On January 8th, 2016, 8:38 a.m. UTC, Boudewijn Rempt wrote:











 

  


Review request for KDE Frameworks and David Faure.


By Boudewijn Rempt.




Updated Jan. 8, 2016, 8:38 a.m.












 Repository: 
kio-extras





Description 

 

 

  
   
KRA and ORA files are mostly the same internally, a zip container with small PNG thumbnail. I would like to move the thumbnailer from krita to kio-extras since it no longer depends on any Krita code, and people who haven't got Krita installed might still want to see krita or openraster thumbnails in Dolphin. The actual author of the code is Frinring.

  		
 







Diffs 


    

 
  • thumbnail/CMakeLists.txt (4addb26)
    • 

 
  • thumbnail/kraorathumbnail.desktop (PRE-CREATION)
    • 

 
  • thumbnail/kritacreator.h (PRE-CREATION)
    • 

 
  • thumbnail/kritacreator.cpp (PRE-CREATION)
    • 





View Diff







  		
 










  

 



--===============4514417905659431179==--

--===============1635655686559228781==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l
d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0
cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo=

--===============1635655686559228781==--