[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126670: Fix some Clazy warnings in KPeople framework
From: "David Faure" <faure () kde ! org>
Date: 2016-01-08 8:12:31
Message-ID: 20160108081231.6499.54404 () mimi ! kde ! org
[Download RAW message or body]
--===============7238735980481634530==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 8, 2016, 1:20 a.m., Aleix Pol Gonzalez wrote:
> > I did it myself because you're a GCI student, but besides compilation, you should \
> > have checked if tests still pass and specified so in the testing field.
> > The change looks, good. Thanks!
>
> Andrey Cygankov wrote:
> Please tell me how to run the auto-tests?
`make test`
For this to work you need to pass -DBUILD_TESTING=TRUE to cmake (but if you use our \
recommended kdesrc-build setup, it does that already)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126670/#review90784
-----------------------------------------------------------
On Jan. 8, 2016, 1:15 a.m., Andrey Cygankov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126670/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 1:15 a.m.)
>
>
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
>
>
> Repository: kpeople
>
>
> Description
> -------
>
> Fix some Clazy warnings:
> - qstring-uneeded-heap-allocations
> - isempty-vs-count
> - detaching-temporary
> - variant-sanitizer
>
>
> Diffs
> -----
>
> autotests/persondatatests.cpp 43a7c7b
> autotests/personsmodeltest.cpp 1cbc3dc
> examples/contactlistwidgets.cpp 56bb01c
> examples/personwidget.cpp b4d73c8
> src/personmanager.cpp 5c3d3e1
> src/personpluginmanager.cpp f5396d9
> src/widgets/actions.cpp ffaf16f
> src/widgets/mergedelegate.cpp 01c988d
> src/widgets/persondetailsview.cpp 7e4e24f
>
> Diff: https://git.reviewboard.kde.org/r/126670/diff/
>
>
> Testing
> -------
>
> Compiling without errors.
>
>
> Thanks,
>
> Andrey Cygankov
>
>
--===============7238735980481634530==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126670/">https://git.reviewboard.kde.org/r/126670/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 8th, 2016, 1:20 a.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I did it myself because you're a GCI student, but \
besides compilation, you should have checked if tests still pass and specified so in \
the testing field.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The change looks, good. \
Thanks!</p></pre> </blockquote>
<p>On January 8th, 2016, 6:23 a.m. UTC, <b>Andrey Cygankov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please tell me how to run the auto-tests?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">make test</code></p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">For this to work you \
need to pass -DBUILD_TESTING=TRUE to cmake (but if you use our recommended \
kdesrc-build setup, it does that already)</p></pre> <br />
<p>- David</p>
<br />
<p>On January 8th, 2016, 1:15 a.m. UTC, Andrey Cygankov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Andrey Cygankov.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2016, 1:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kpeople
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix some Clazy warnings:
- qstring-uneeded-heap-allocations
- isempty-vs-count
- detaching-temporary
- variant-sanitizer</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiling without errors.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/persondatatests.cpp <span style="color: grey">(43a7c7b)</span></li>
<li>autotests/personsmodeltest.cpp <span style="color: grey">(1cbc3dc)</span></li>
<li>examples/contactlistwidgets.cpp <span style="color: grey">(56bb01c)</span></li>
<li>examples/personwidget.cpp <span style="color: grey">(b4d73c8)</span></li>
<li>src/personmanager.cpp <span style="color: grey">(5c3d3e1)</span></li>
<li>src/personpluginmanager.cpp <span style="color: grey">(f5396d9)</span></li>
<li>src/widgets/actions.cpp <span style="color: grey">(ffaf16f)</span></li>
<li>src/widgets/mergedelegate.cpp <span style="color: grey">(01c988d)</span></li>
<li>src/widgets/persondetailsview.cpp <span style="color: \
grey">(7e4e24f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126670/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7238735980481634530==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic