From kde-frameworks-devel Fri Jan 08 08:12:31 2016 From: "David Faure" Date: Fri, 08 Jan 2016 08:12:31 +0000 To: kde-frameworks-devel Subject: Re: Review Request 126670: Fix some Clazy warnings in KPeople framework Message-Id: <20160108081231.6499.54404 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=145224077708201 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8624712278835418103==" --===============8624712278835418103== Content-Type: multipart/alternative; boundary="===============7238735980481634530==" --===============7238735980481634530== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 8, 2016, 1:20 a.m., Aleix Pol Gonzalez wrote: > > I did it myself because you're a GCI student, but besides compilation, you should have checked if tests still pass and specified so in the testing field. > > > > The change looks, good. Thanks! > > Andrey Cygankov wrote: > Please tell me how to run the auto-tests? `make test` For this to work you need to pass -DBUILD_TESTING=TRUE to cmake (but if you use our recommended kdesrc-build setup, it does that already) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126670/#review90784 ----------------------------------------------------------- On Jan. 8, 2016, 1:15 a.m., Andrey Cygankov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126670/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 1:15 a.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kpeople > > > Description > ------- > > Fix some Clazy warnings: > - qstring-uneeded-heap-allocations > - isempty-vs-count > - detaching-temporary > - variant-sanitizer > > > Diffs > ----- > > autotests/persondatatests.cpp 43a7c7b > autotests/personsmodeltest.cpp 1cbc3dc > examples/contactlistwidgets.cpp 56bb01c > examples/personwidget.cpp b4d73c8 > src/personmanager.cpp 5c3d3e1 > src/personpluginmanager.cpp f5396d9 > src/widgets/actions.cpp ffaf16f > src/widgets/mergedelegate.cpp 01c988d > src/widgets/persondetailsview.cpp 7e4e24f > > Diff: https://git.reviewboard.kde.org/r/126670/diff/ > > > Testing > ------- > > Compiling without errors. > > > Thanks, > > Andrey Cygankov > > --===============7238735980481634530== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126670/

On January 8th, 2016, 1:20 a.m. UTC, Aleix Pol Gonzalez wrote:

I did it myself because you're a GCI student, but besides compilation, you should have checked if tests still pass and specified so in the testing field.


The change looks, good. Thanks!

On January 8th, 2016, 6:23 a.m. UTC, Andrey Cygankov wrote:

Please tell me how to run the auto-tests?
make test


For this to work you need to pass -DBUILD_TESTING=TRUE to cmake (but if you use our recommended kdesrc-build setup, it does that already)

- David


On January 8th, 2016, 1:15 a.m. UTC, Andrey Cygankov wrote:

Review request for KDE Frameworks and Aleix Pol Gonzalez.
By Andrey Cygankov.

Updated Jan. 8, 2016, 1:15 a.m.

Repository: kpeople

Description 

Fix some Clazy warnings:
- qstring-uneeded-heap-allocations
- isempty-vs-count
- detaching-temporary
- variant-sanitizer

Testing 

Compiling without errors.

Diffs

  • autotests/persondatatests.cpp (43a7c7b)
  • autotests/personsmodeltest.cpp (1cbc3dc)
  • examples/contactlistwidgets.cpp (56bb01c)
  • examples/personwidget.cpp (b4d73c8)
  • src/personmanager.cpp (5c3d3e1)
  • src/personpluginmanager.cpp (f5396d9)
  • src/widgets/actions.cpp (ffaf16f)
  • src/widgets/mergedelegate.cpp (01c988d)
  • src/widgets/persondetailsview.cpp (7e4e24f)

View Diff
--===============7238735980481634530==-- --===============8624712278835418103== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============8624712278835418103==--