[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date
From: "David Faure" <faure () kde ! org>
Date: 2016-01-07 12:25:45
Message-ID: 20160107122545.6499.74219 () mimi ! kde ! org
[Download RAW message or body]
--===============5767768928734185566==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126659/#review90750
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Jan. 7, 2016, 12:23 p.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126659/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 12:23 p.m.)
>
>
> Review request for KDE Frameworks, kdelibs and David Faure.
>
>
> Bugs: 354597
> https://bugs.kde.org/show_bug.cgi?id=354597
>
>
> Repository: kio
>
>
> Description
> -------
>
> - QDate() treats the year literally (i.e. 90 is really year 90, not 1990), so \
> subtracting 1900 is wrong.
> - Use QDate::currentDate() instead of QDateTime::currentDateTime(), we only need \
> the current date anyway
> - Initialize day, month, and year to the current date instead of 0. In the case \
> when no year is mentioned in the server's reply (the year is implicit), it wasn't \
> set to the current year at all, so the result was either 0 or -1.
>
> Diffs
> -----
>
> src/ioslaves/ftp/ftp.cpp 2179179
>
> Diff: https://git.reviewboard.kde.org/r/126659/diff/
>
>
> Testing
> -------
>
> Connected to an FTP server with dolphin (15.12.0). The modification times/dates are \
> now shown correctly.
>
> Thanks,
>
> Wolfgang Bauer
>
>
--===============5767768928734185566==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126659/">https://git.reviewboard.kde.org/r/126659/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Faure</p>
<br />
<p>On January 7th, 2016, 12:23 p.m. UTC, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, kdelibs and David Faure.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2016, 12:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=354597">354597</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">QDate() treats the year \
literally (i.e. 90 is really year 90, not 1990), so subtracting 1900 is wrong.</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Use QDate::currentDate() instead of \
QDateTime::currentDateTime(), we only need the current date anyway</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Initialize day, month, and year to the current date instead of 0. In the \
case when no year is mentioned in the server's reply (the year is implicit), it \
wasn't set to the current year at all, so the result was either 0 or -1.</li> \
</ul></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Connected to an FTP server with dolphin (15.12.0). The \
modification times/dates are now shown correctly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(2179179)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126659/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5767768928734185566==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic