'Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-frameworks-devel
Subject: Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date
From: "David Faure" <faure () kde ! org>
Date: 2016-01-07 12:25:09
Message-ID: 20160107122509.6499.27162 () mimi ! kde ! org
[Download RAW message or body]

--===============3391561441690005270==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Jan. 7, 2016, 11:15 a.m., David Faure wrote:
> > src/ioslaves/ftp/ftp.cpp, line 1775
> > <https://git.reviewboard.kde.org/r/126659/diff/1/?file=428702#file428702line1775>
> > 
> > The porting bug is here. In kdelibs4 tmptr was initialized to the current date, \
> > and used below. 
> > Now we have two variables, "int year" and "currentTime.year".
> > 
> > To be closer to the orig code and to avoid risking that the day or month is still \
> > 0 as well, I would suggest to initialize year, day and month directly from \
> > currentTime, rather than to 0. 
> > I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) because that's \
> > unused (right?)
> 
> Wolfgang Bauer wrote:
> > To be closer to the orig code and to avoid risking that the day or month is still \
> > 0 as well, I would suggest to initialize year, day and month directly from \
> > currentTime, rather than to 0.
> 
> Well, if we don't know the values, taking them from currentTime is likely just as \
> wrong as setting them to 0. But ok, I'll change it.
> 
> > I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) because that's \
> > unused (right?)
> 
> Right, it is unused AFAICS.
> Actually we could also just use QDate::currentDate() instead of \
> QDateTime::currentDateTime() IMHO.

"likely just as wrong" - well with 0 the QDateTime would be invalid, making the whole \
information disappear (even e.g. the valid time information). So using the current \
datetime (as kdelibs4 did) seems better.

Agreed about currentDate().

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126659/#review90743
-----------------------------------------------------------

On Jan. 7, 2016, 12:23 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126659/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 12:23 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Bugs: 354597
> https://bugs.kde.org/show_bug.cgi?id=354597
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> - QDate() treats the year literally (i.e. 90 is really year 90, not 1990), so \
>                 subtracting 1900 is wrong.
> - Use QDate::currentDate() instead of QDateTime::currentDateTime(), we only need \
>                 the current date anyway
> - Initialize day, month, and year to the current date instead of 0. In the case \
> when no year is mentioned in the server's reply (the year is implicit), it wasn't \
> set to the current year at all, so the result was either 0 or -1. 
> 
> Diffs
> -----
> 
> src/ioslaves/ftp/ftp.cpp 2179179 
> 
> Diff: https://git.reviewboard.kde.org/r/126659/diff/
> 
> 
> Testing
> -------
> 
> Connected to an FTP server with dolphin (15.12.0). The modification times/dates are \
> now shown correctly. 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
> 

--===============3391561441690005270==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126659/">https://git.reviewboard.kde.org/r/126659/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On January 7th, 2016, 11:15 a.m. UTC, <b>David \
Faure</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/126659/diff/1/?file=428702#file428702line1775" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/ioslaves/ftp/ftp.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
Ftp::ftpReadDir(FtpEntry &amp;de)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1775</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="kt">int</span> <span class="n">year</span> <span class="o">=</span> <span \
class="mi">0</span><span class="p">;</span></pre></td>  <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1775</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="kt">int</span> <span class="n">year</span> <span class="o">=</span> <span \
class="mi">0</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
porting bug is here. In kdelibs4 tmptr was initialized to the current date, and used \
below.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now we have two variables, "int year" and \
"currentTime.year".</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">To be closer to the orig code and to \
avoid risking that the day or month is still 0 as well, I would suggest to initialize \
year, day and month directly from currentTime, rather than to 0.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) because \
that's unused (right?)</p></pre>  </blockquote>

 <p>On January 7th, 2016, 12:21 p.m. UTC, <b>Wolfgang Bauer</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">To be closer to the orig code and to avoid risking that the day or month is \
still 0 as well, I would suggest to initialize year, day and month directly from \
currentTime, rather than to 0.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Well, if we don't know the values, taking them from \
currentTime is likely just as wrong as setting them to 0. But ok, I'll change it.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) because \
that's unused (right?)</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Right, it is unused AFAICS. Actually we could also \
just use QDate::currentDate() instead of QDateTime::currentDateTime() IMHO.</p></pre> \
</blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"likely just as wrong" - well with 0 the QDateTime would be invalid, making \
the whole information disappear (even e.g. the valid time information). So using the \
current datetime (as kdelibs4 did) seems better. Agreed about currentDate().</pre>

<p>- David</p>

<br />
<p>On January 7th, 2016, 12:23 p.m. UTC, Wolfgang Bauer wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, kdelibs and David Faure.</div>
<div>By Wolfgang Bauer.</div>

<p style="color: grey;"><i>Updated Jan. 7, 2016, 12:23 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=354597">354597</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">QDate() treats the year \
literally (i.e. 90 is really year 90, not 1990), so subtracting 1900 is wrong.</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Use QDate::currentDate() instead of \
QDateTime::currentDateTime(), we only need the current date anyway</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Initialize day, month, and year to the current date instead of 0. In the \
case when no year is mentioned in the server's reply (the year is implicit), it \
wasn't set to the current year at all, so the result was either 0 or -1.</li> \
</ul></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Connected to an FTP server with dolphin (15.12.0). The \
modification times/dates are now shown correctly.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(2179179)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126659/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3391561441690005270==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 