'Re: Review Request 126648: Allow to disable KArchive for internal usage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126648: Allow to disable KArchive for internal usage
From:       "David Faure" <faure () kde ! org>
Date:       2016-01-07 8:33:04
Message-ID: 20160107083304.6499.14705 () mimi ! kde ! org
[Download RAW message or body]

--===============8913199488832146670==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126648/#review90735
-----------------------------------------------------------

Ship it!

Ship It!

- David Faure

On Jan. 6, 2016, 9:33 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126648/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 9:33 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Alex Merry, and David Faure.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Most of the code was already prepared to compile without the KArchive dependency (including \
> the MEINPROC_NO_KARCHIVE flag). This mode should be only enabled on KDE infrastructure, as \
> the compressed cache (the only added feature coming from KArchive) is not used by the \
> generator of the documentation website. A warning is printed when the mode is enabled.
> The saveToCache function is preserved, even if without code, to minimize the changes \
> required. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 2ec3027 
> src/CMakeLists.txt 136fbfb 
> src/xslt_kde.cpp 7069a28 
> 
> Diff: https://git.reviewboard.kde.org/r/126648/diff/
> 
> 
> Testing
> -------
> 
> Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
> 

--===============8913199488832146670==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126648/">https://git.reviewboard.kde.org/r/126648/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- David Faure</p>

<br />
<p>On January 6th, 2016, 9:33 p.m. UTC, Luigi Toscano wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Build System, KDE Frameworks, Alex Merry, and David Faure.</div>
<div>By Luigi Toscano.</div>

<p style="color: grey;"><i>Updated Jan. 6, 2016, 9:33 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Most of the code was \
already prepared to compile without the KArchive dependency (including the MEINPROC_NO_KARCHIVE \
flag). This mode should be only enabled on KDE infrastructure, as the compressed cache (the \
only added feature coming from KArchive) is not used by the generator of the documentation \
website. A warning is printed when the mode is enabled.
The saveToCache function is preserved, even if without code, to minimize the changes \
required.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Normal compilation, \
compilation with MEINPROC_NO_KARCHIVE=ON</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(2ec3027)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(136fbfb)</span></li>

 <li>src/xslt_kde.cpp <span style="color: grey">(7069a28)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126648/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8913199488832146670==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 