From kde-frameworks-devel Thu Jan 07 08:33:04 2016 From: "David Faure" Date: Thu, 07 Jan 2016 08:33:04 +0000 To: kde-frameworks-devel Subject: Re: Review Request 126648: Allow to disable KArchive for internal usage Message-Id: <20160107083304.6499.14705 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=145215561717216 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8750719115827933278==" --===============8750719115827933278== Content-Type: multipart/alternative; boundary="===============8913199488832146670==" --===============8913199488832146670== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126648/#review90735 ----------------------------------------------------------- Ship it! Ship It! - David Faure On Jan. 6, 2016, 9:33 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126648/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 9:33 p.m.) > > > Review request for Build System, KDE Frameworks, Alex Merry, and David Faure. > > > Repository: kdoctools > > > Description > ------- > > Most of the code was already prepared to compile without the KArchive dependency (including the MEINPROC_NO_KARCHIVE flag). > This mode should be only enabled on KDE infrastructure, as the compressed cache (the only added feature coming from KArchive) is not used by the generator of the documentation website. > A warning is printed when the mode is enabled. > The saveToCache function is preserved, even if without code, to minimize the changes required. > > > Diffs > ----- > > CMakeLists.txt 2ec3027 > src/CMakeLists.txt 136fbfb > src/xslt_kde.cpp 7069a28 > > Diff: https://git.reviewboard.kde.org/r/126648/diff/ > > > Testing > ------- > > Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON > > > Thanks, > > Luigi Toscano > > --===============8913199488832146670== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126648/

Ship it!

Ship It!

- David Faure

On January 6th, 2016, 9:33 p.m. UTC, Luigi Toscano wrote:

Review request for Build System, KDE Frameworks, Alex Merry, and David Faure.

By Luigi Toscano.

Updated Jan. 6, 2016, 9:33 p.m.

Repository: kdoctools

Description

Most of the code was already prepared to compile without the KArchive dependency (including the MEINPROC_NO_KARCHIVE flag).
This mode should be only enabled on KDE infrastructure, as the compressed cache (the only added feature coming from KArchive) is not used by the generator of the documentation website.
A warning is printed when the mode is enabled.
The saveToCache function is preserved, even if without code, to minimize the changes required.

Testing

Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON

Diffs

CMakeLists.txt (2ec3027)
src/CMakeLists.txt (136fbfb)
src/xslt_kde.cpp (7069a28)

View Diff

--===============8913199488832146670==-- --===============8750719115827933278== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============8750719115827933278==--