'Re: Review Request 124147: Create Data Dir If it Does Not Exist'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 124147: Create Data Dir If it Does Not Exist
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2015-12-10 6:55:41
Message-ID: 20151210065541.30410.5132 () mimi ! kde ! org
[Download RAW message or body]

--===============3029677347231134177==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124147/
-----------------------------------------------------------

(Updated Dec. 10, 2015, 6:55 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks.

Changes
-------

Submitted with commit 308155ba6f095e37c348fbb3a74774948280fc7c by David E. Narvaez to \
branch master.

Repository: kio

Description
-------

Prevents a cold start bug when the data dir is not created. Also, by
storing the file name as a member of the KCookieServer class we avoid
calculating it every time cookies are saved.

Diffs
-----

  src/ioslaves/http/kcookiejar/kcookieserver.h \
f61c7d0e4da58b805565632cf3dd484445c21275   \
src/ioslaves/http/kcookiejar/kcookieserver.cpp \
ac585a0b04637c485647564d18a89a75d6c11d97 

Diff: https://git.reviewboard.kde.org/r/124147/diff/

Testing
-------

Restarted kded5 with no file named kcookiejar inside ~/.local/share and with a \
regular file named kcookiejar in that location.

In my setup, the message box is not showing properly but I am not sure if this is \
somethign that happens only on my computer or if this is something wrong with the \
code, can somebody confirm?

Thanks,

David Narváez

--===============3029677347231134177==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124147/">https://git.reviewboard.kde.org/r/124147/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated Dec. 10, 2015, 6:55 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 308155ba6f095e37c348fbb3a74774948280fc7c by David \
E. Narvaez to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Prevents a cold start bug when the data dir is not created. Also, by \
storing the file name as a member of the KCookieServer class we avoid calculating it \
every time cookies are saved.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Restarted kded5 with no file named kcookiejar inside \
~/.local/share and with a regular file named kcookiejar in that location.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">In my setup, the message box is not showing properly but I am not sure if \
this is somethign that happens only on my computer or if this is something wrong with \
the code, can somebody confirm?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ioslaves/http/kcookiejar/kcookieserver.h <span style="color: \
grey">(f61c7d0e4da58b805565632cf3dd484445c21275)</span></li>

 <li>src/ioslaves/http/kcookiejar/kcookieserver.cpp <span style="color: \
grey">(ac585a0b04637c485647564d18a89a75d6c11d97)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124147/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3029677347231134177==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 