[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 124147: Create Data Dir If it Does Not Exist
From: "David Faure" <faure () kde ! org>
Date: 2015-11-08 10:42:47
Message-ID: 20151108104247.18220.53533 () mimi ! kde ! org
[Download RAW message or body]
--===============6050920274254774997==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124147/#review88157
-----------------------------------------------------------
Ship it!
sorry about the delay, this fell through the cracks. Don't hesitate to ping when this \
happens...
src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 68)
<https://git.reviewboard.kde.org/r/124147/#comment60466>
make that QDir(kcookiejarDirName), like the other return statement.
src/ioslaves/http/kcookiejar/kcookieserver.cpp (line 73)
<https://git.reviewboard.kde.org/r/124147/#comment60467>
I suppose this should be Q_NULLPTR instead.
- David Faure
On July 23, 2015, 5:19 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124147/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 5:19 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Prevents a cold start bug when the data dir is not created. Also, by
> storing the file name as a member of the KCookieServer class we avoid
> calculating it every time cookies are saved.
>
>
> Diffs
> -----
>
> src/ioslaves/http/kcookiejar/kcookieserver.h \
> f61c7d0e4da58b805565632cf3dd484445c21275 \
> src/ioslaves/http/kcookiejar/kcookieserver.cpp \
> ac585a0b04637c485647564d18a89a75d6c11d97
> Diff: https://git.reviewboard.kde.org/r/124147/diff/
>
>
> Testing
> -------
>
> Restarted kded5 with no file named kcookiejar inside ~/.local/share and with a \
> regular file named kcookiejar in that location.
> In my setup, the message box is not showing properly but I am not sure if this is \
> somethign that happens only on my computer or if this is something wrong with the \
> code, can somebody confirm?
>
> Thanks,
>
> David Narváez
>
>
--===============6050920274254774997==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124147/">https://git.reviewboard.kde.org/r/124147/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry about the delay, \
this fell through the cracks. Don't hesitate to ping when this happens...</pre> \
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124147/diff/6/?file=386753#file386753line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/ioslaves/http/kcookiejar/kcookieserver.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span> <span class="n">kcookiejarDirName</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">make \
that QDir(kcookiejarDirName), like the other return statement.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124147/diff/6/?file=386753#file386753line73" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/ioslaves/http/kcookiejar/kcookieserver.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">73</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QMessageBox</span><span class="o">::</span><span \
class="n">warning</span><span class="p">(</span><span class="k">nullptr</span><span \
class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span \
class="s">"Cannot Save Cookies"</span><span class="p">),</span> <span \
class="n">i18n</span><span class="p">(</span><span class="s">"Could not create \
directory %1"</span><span class="p">).</span><span class="n">arg</span><span \
class="p">(</span><span class="n">kcookiejarDirName</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
suppose this should be Q_NULLPTR instead.</p></pre> </div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On July 23rd, 2015, 5:19 a.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated July 23, 2015, 5:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Prevents a cold start bug when the data dir is not created. Also, by \
storing the file name as a member of the KCookieServer class we avoid calculating it \
every time cookies are saved.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Restarted kded5 with no file named kcookiejar inside \
~/.local/share and with a regular file named kcookiejar in that location.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">In my setup, the message box is not showing properly but I am not sure if \
this is somethign that happens only on my computer or if this is something wrong with \
the code, can somebody confirm?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/kcookiejar/kcookieserver.h <span style="color: \
grey">(f61c7d0e4da58b805565632cf3dd484445c21275)</span></li>
<li>src/ioslaves/http/kcookiejar/kcookieserver.cpp <span style="color: \
grey">(ac585a0b04637c485647564d18a89a75d6c11d97)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124147/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6050920274254774997==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic