'Re: Review Request 126245: Cookie dialogue: make Accept/Reject buttons work, and other fixes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126245: Cookie dialogue: make Accept/Reject buttons work, and other fixes
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2015-12-06 19:56:12
Message-ID: 20151206195612.29696.91391 () mimi ! kde ! org
[Download RAW message or body]

--===============2252239959829075586==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126245/
-----------------------------------------------------------

(Updated Dec. 6, 2015, 7:56 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks.

Changes
-------

Submitted with commit ed61726878fc6a4cd9f2741e3ab67db34f78f0ca by Jonathan Marten to \
branch master.

Repository: kio

Description
-------

The "You received a cookie from..." dialogue appears, but there are a number of \
things that do not work as intended.  This patch corrects them.

1. The first two buttons were presumably intended to be "Accept" and "Reject" as for \
KDE4, but they actually said "Reject" and "No".  This was a simple cut/paste error.

2. Clicking either of these buttons did nothing.  They needed to be connected to \
accept() and reject() in order to make the exec() called from \
KCookieServer::checkCookies() return a result.

3. The "Set or modify the cookie information" button text was too wide, making the \
dialogue width far wider than needed for the cookie information.  The dialogue looks \
better with this changed back to "Details" (with the same icon as for KDE4) with the \
full text in a tooltip.

4. The state of the hide/show details was not being saved correctly.  Using \
!isHidden() instead of isVisible() gets the correct information.

Diffs
-----

  src/ioslaves/http/kcookiejar/kcookiewin.cpp 56a283f 

Diff: https://git.reviewboard.kde.org/r/126245/diff/

Testing
-------

Built kio with these changes, checked operation of the cookie dialogue in Konqueror.

Thanks,

Jonathan Marten

--===============2252239959829075586==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126245/">https://git.reviewboard.kde.org/r/126245/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Jonathan Marten.</div>

<p style="color: grey;"><i>Updated Dec. 6, 2015, 7:56 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit ed61726878fc6a4cd9f2741e3ab67db34f78f0ca by \
Jonathan Marten to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The "You received a cookie from..." dialogue appears, \
but there are a number of things that do not work as intended.  This patch corrects \
them.</p> <ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
first two buttons were presumably intended to be "Accept" and "Reject" as for KDE4, \
but they actually said "Reject" and "No".  This was a simple cut/paste error.</p> \
</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Clicking either of these buttons did \
nothing.  They needed to be connected to accept() and reject() in order to make the \
exec() called from KCookieServer::checkCookies() return a result.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The "Set or modify the cookie \
information" button text was too wide, making the dialogue width far wider than \
needed for the cookie information.  The dialogue looks better with this changed back \
to "Details" (with the same icon as for KDE4) with the full text in a tooltip.</p> \
</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The state of the hide/show details was \
not being saved correctly.  Using !isHidden() instead of isVisible() gets the correct \
information.</p> </li>
</ol></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built kio with these changes, checked operation of the \
cookie dialogue in Konqueror.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ioslaves/http/kcookiejar/kcookiewin.cpp <span style="color: \
grey">(56a283f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126245/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2252239959829075586==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 