[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126245: Cookie dialogue: make Accept/Reject buttons work, and other fixes
From: "David Faure" <faure () kde ! org>
Date: 2015-12-06 8:46:52
Message-ID: 20151206084652.29696.10343 () mimi ! kde ! org
[Download RAW message or body]
--===============4073265643268140994==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126245/#review89163
-----------------------------------------------------------
Ship it!
Yep, looks 100% correct.
I'm surprised that there are still people using this dialog though, I was considering \
removing it :-). The default settings (for many years) are to not show this dialog, I \
assume you change the settings so that it is shown?
- David Faure
On Dec. 4, 2015, 5:16 p.m., Jonathan Marten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126245/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 5:16 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> The "You received a cookie from..." dialogue appears, but there are a number of \
> things that do not work as intended. This patch corrects them.
> 1. The first two buttons were presumably intended to be "Accept" and "Reject" as \
> for KDE4, but they actually said "Reject" and "No". This was a simple cut/paste \
> error.
> 2. Clicking either of these buttons did nothing. They needed to be connected to \
> accept() and reject() in order to make the exec() called from \
> KCookieServer::checkCookies() return a result.
> 3. The "Set or modify the cookie information" button text was too wide, making the \
> dialogue width far wider than needed for the cookie information. The dialogue \
> looks better with this changed back to "Details" (with the same icon as for KDE4) \
> with the full text in a tooltip.
> 4. The state of the hide/show details was not being saved correctly. Using \
> !isHidden() instead of isVisible() gets the correct information.
>
> Diffs
> -----
>
> src/ioslaves/http/kcookiejar/kcookiewin.cpp 56a283f
>
> Diff: https://git.reviewboard.kde.org/r/126245/diff/
>
>
> Testing
> -------
>
> Built kio with these changes, checked operation of the cookie dialogue in \
> Konqueror.
>
> Thanks,
>
> Jonathan Marten
>
>
--===============4073265643268140994==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126245/">https://git.reviewboard.kde.org/r/126245/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yep, \
looks 100% correct.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'm surprised that there are still \
people using this dialog though, I was considering removing it :-). The default \
settings (for many years) are to not show this dialog, I assume you change the \
settings so that it is shown?</p></pre> <br />
<p>- David Faure</p>
<br />
<p>On December 4th, 2015, 5:16 p.m. UTC, Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2015, 5:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The "You received a cookie from..." dialogue appears, \
but there are a number of things that do not work as intended. This patch corrects \
them.</p> <ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;"> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
first two buttons were presumably intended to be "Accept" and "Reject" as for KDE4, \
but they actually said "Reject" and "No". This was a simple cut/paste error.</p> \
</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Clicking either of these buttons did \
nothing. They needed to be connected to accept() and reject() in order to make the \
exec() called from KCookieServer::checkCookies() return a result.</p> </li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The "Set or modify the cookie \
information" button text was too wide, making the dialogue width far wider than \
needed for the cookie information. The dialogue looks better with this changed back \
to "Details" (with the same icon as for KDE4) with the full text in a tooltip.</p> \
</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The state of the hide/show details was \
not being saved correctly. Using !isHidden() instead of isVisible() gets the correct \
information.</p> </li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built kio with these changes, checked operation of the \
cookie dialogue in Konqueror.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/kcookiejar/kcookiewin.cpp <span style="color: \
grey">(56a283f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126245/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4073265643268140994==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic