[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2015-11-18 14:38:57
Message-ID: 20151118143857.14400.95334 () mimi ! kde ! org
[Download RAW message or body]
--===============0120277212050538436==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Nov. 17, 2015, 11:58 p.m., Lamarque Souza wrote:
> > src/plugins/osx/macpoller_helper.mm, line 54
> > <https://git.reviewboard.kde.org/r/126078/diff/6/?file=417218#file417218line54>
> >
> > Usually when a new operation returns 0 it is because system is on short on RAM \
> > memory (or memory is too fragmented). I would add assert here instead of silently \
> > ignoring the failure to allocate memory.
And I would argue that it is up to the calling software to decide how to react to a \
failure to set up idle detection: in this case it's only the "resume from idle" \
functionality that can no longer work. The idle timeout detection feature should \
still be able to function (possibly by adding some kind of reset when the calculated \
idle time returns to 0). Asserting would mean that the application aborts, which I \
find a bit overkill for a situation that could be handled a lot more elegantly. That \
would require handling the return value from `setupPoller()` in \
`KIdleTimePrivate::loadSystem()` and up, of course.
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126078/#review88505
-----------------------------------------------------------
On Nov. 17, 2015, 10:13 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126078/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 10:13 p.m.)
>
>
> Review request for KDE Software on Mac OS X, KDE Frameworks and Dario Freddi.
>
>
> Repository: kidletime
>
>
> Description
> -------
>
> I noticed that the KIdleTime example doesn't work properly on OS X, and that the \
> plugin for OS X still uses the deprecated Carbon-based algorithm that I already \
> patched for KDE4.
> This patch is a work-in-progress (hence the qDebugs) update to use IOKit, \
> IORegistry and CoreServices to do idle-time calculation as it should be done, and \
> allow simulated user activity through a "less deprecated" function.
>
> Diffs
> -----
>
> src/plugins/osx/CMakeLists.txt e1b50b8
> src/plugins/osx/macpoller.h ef51ea5
> src/plugins/osx/macpoller.cpp ad9c10f
> src/plugins/osx/macpoller_helper.mm PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/126078/diff/
>
>
> Testing
> -------
>
> On OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 .
>
> The example now works: when I set a QTimer with interval==0, the expected wait for \
> user input (`resumingFromIdle` signal) works. However, I am getting a \
> `stopCatchingIdleEvents` signal which means the application waits forever, without \
> ever getting to compare idle time to the list of timeouts. I haven't been able to \
> figure out where that signal comes from, nor why this doesn't happen on Linux.
> Surely I'm missing something, but what?
>
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============0120277212050538436==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126078/">https://git.reviewboard.kde.org/r/126078/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 17th, 2015, 11:58 p.m. CET, \
<b>Lamarque Souza</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: \
2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126078/diff/6/?file=417218#file417218line54" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plugins/osx/macpoller_helper.mm</a> <span style="font-weight: \
normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">54</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">nativeGrabber</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Usually when a new operation returns 0 it is because system is on short on \
RAM memory (or memory is too fragmented). I would add assert here instead of silently \
ignoring the failure to allocate memory.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">And I would argue that it is up to the calling software to decide how to \
react to a failure to set up idle detection: in this case it's only the "resume from \
idle" functionality that can no longer work. The idle timeout detection feature \
should still be able to function (possibly by adding some kind of reset when the \
calculated idle time returns to 0). Asserting would mean that the application aborts, \
which I find a bit overkill for a situation that could be handled a lot more \
elegantly. That would require handling the return value from <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">setupPoller()</code> in <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">KIdleTimePrivate::loadSystem()</code> and up, of course.</p></pre> <br />
<p>- René J.V.</p>
<br />
<p>On November 17th, 2015, 10:13 p.m. CET, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Frameworks and Dario \
Freddi.</div> <div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Nov. 17, 2015, 10:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kidletime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I noticed that the KIdleTime example doesn't work \
properly on OS X, and that the plugin for OS X still uses the deprecated Carbon-based \
algorithm that I already patched for KDE4.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is a \
work-in-progress (hence the qDebugs) update to use IOKit, IORegistry and CoreServices \
to do idle-time calculation as it should be done, and allow simulated user activity \
through a "less deprecated" function.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 .</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The example now works: when I set a QTimer with \
interval==0, the expected wait for user input (<code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">resumingFromIdle</code> signal) works. However, I am getting a <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">stopCatchingIdleEvents</code> signal which means the \
application waits forever, without ever getting to compare idle time to the list of \
timeouts. I haven't been able to figure out where that signal comes from, nor why \
this doesn't happen on Linux.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Surely I'm missing \
something, but what?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/osx/CMakeLists.txt <span style="color: grey">(e1b50b8)</span></li>
<li>src/plugins/osx/macpoller.h <span style="color: grey">(ef51ea5)</span></li>
<li>src/plugins/osx/macpoller.cpp <span style="color: grey">(ad9c10f)</span></li>
<li>src/plugins/osx/macpoller_helper.mm <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126078/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0120277212050538436==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic