[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 125815: Provide an alternative when khelpcenter is not available
From: "Nick Shaforostoff" <shafff () ukr ! net>
Date: 2015-11-06 17:38:33
Message-ID: 20151106173833.24343.90370 () mimi ! kde ! org
[Download RAW message or body]
--===============7689622063022633809==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/#review88105
-----------------------------------------------------------
src/util/urlhandler.cpp (line 49)
<https://git.reviewboard.kde.org/r/125815/#comment60442>
there is no point in using QStringLiteral there as a deep copy is done anyways. \
using QLatin1String would take almost the same time, except that the .so binary would \
be smaller.
instead for QStandardPaths::findExecutable it does make sense to use \
QStringLiteral
- Nick Shaforostoff
On Nov. 6, 2015, 4:48 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125815/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 4:48 p.m.)
>
>
> Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.
>
>
> Repository: kguiaddons
>
>
> Description
> -------
>
> Tries to reach out to docs.kde.org when khelpcenter is not available.
>
>
> Diffs
> -----
>
> src/util/urlhandler.cpp 5b46be2
>
> Diff: https://git.reviewboard.kde.org/r/125815/diff/
>
>
> Testing
> -------
>
> I tried it with a couple of applications. For the main documentation just works.
>
> Needs figuring out for more complex cases, I'm unsure if applications are opening \
> the documentation in specific pages. In fact, I couldn't find the documentation for \
> docs.kde.org url scheme, and I just made up the `path` part, although it seems to \
> work.
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============7689622063022633809==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125815/">https://git.reviewboard.kde.org/r/125815/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125815/diff/1/?file=412871#file412871line49" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/util/urlhandler.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public \
Q_SLOTS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">49</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">QUrl</span> <span class="n">httpUrl</span><span \
class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"https://docs.kde.org/index.php?branch=stable5&application="</span><span \
class="p">)</span> <span class="o">+</span> <span \
class="n">QCoreApplication</span><span class="o">::</span><span \
class="n">applicationName</span><span class="p">()</span> <span class="o">+</span> \
<span class="n">QStringLiteral</span><span class="p">(</span><span \
class="s">"&path="</span><span class="p">)</span> <span \
class="o">+</span> <span class="n">url</span><span class="p">.</span><span \
class="n">path</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there is no point in \
using QStringLiteral there as a deep copy is done anyways. using QLatin1String would \
take almost the same time, except that the .so binary would be smaller.
instead for QStandardPaths::findExecutable it does make sense to use \
QStringLiteral</pre> </div>
</div>
<br />
<p>- Nick Shaforostoff</p>
<br />
<p>On November 6th, 2015, 4:48 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2015, 4:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kguiaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tries to reach out to docs.kde.org when khelpcenter is \
not available.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I tried it with a couple of applications. For the main \
documentation just works.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Needs figuring out for more complex \
cases, I'm unsure if applications are opening the documentation in specific pages. In \
fact, I couldn't find the documentation for docs.kde.org url scheme, and I just made \
up the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">path</code> part, although it seems to \
work.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/util/urlhandler.cpp <span style="color: grey">(5b46be2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125815/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7689622063022633809==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic