'Re: Review Request 125815: Provide an alternative when khelpcenter is not available'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 125815: Provide an alternative when khelpcenter is not available
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2015-11-06 16:48:18
Message-ID: 20151106164818.24343.16226 () mimi ! kde ! org
[Download RAW message or body]

--===============8981413938275453995==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125815/
-----------------------------------------------------------

(Updated Nov. 6, 2015, 4:48 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.

Changes
-------

Submitted with commit c61b3a8acfd013e50219e62da68f300ab43acfaf by Aleix Pol to branch \
master.

Repository: kguiaddons

Description
-------

Tries to reach out to docs.kde.org when khelpcenter is not available.

Diffs
-----

  src/util/urlhandler.cpp 5b46be2 

Diff: https://git.reviewboard.kde.org/r/125815/diff/

Testing
-------

I tried it with a couple of applications. For the main documentation just works.

Needs figuring out for more complex cases, I'm unsure if applications are opening the \
documentation in specific pages. In fact, I couldn't find the documentation for \
docs.kde.org url scheme, and I just made up the `path` part, although it seems to \
work.

Thanks,

Aleix Pol Gonzalez

--===============8981413938275453995==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125815/">https://git.reviewboard.kde.org/r/125815/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Nov. 6, 2015, 4:48 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit c61b3a8acfd013e50219e62da68f300ab43acfaf by Aleix \
Pol to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kguiaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tries to reach out to docs.kde.org when khelpcenter is \
not available.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I tried it with a couple of applications. For the main \
documentation just works.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Needs figuring out for more complex \
cases, I'm unsure if applications are opening the documentation in specific pages. In \
fact, I couldn't find the documentation for docs.kde.org url scheme, and I just made \
up the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">path</code> part, although it seems to \
work.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/util/urlhandler.cpp <span style="color: grey">(5b46be2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125815/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8981413938275453995==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 