'Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs
From:       "Allen Winter" <winter () kde ! org>
Date:       2015-05-25 17:39:32
Message-ID: 20150525173932.17589.65070 () mimi ! kde ! org
[Download RAW message or body]

--===============4678482730803290216==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123867/#review80817
-----------------------------------------------------------

This is incorrect.  std::abs comes from cstdlib, not cmath
please fix accordingly.  I have it compiling here fine on my macbook with #include \
<cstdlib> instead of #include <cmath>

- Allen Winter

On May 21, 2015, 8:19 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123867/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 8:19 a.m.)
> 
> 
> Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett Clark.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/1/console
>  
> Follow up to,
> 
> commit 8d392e523e4556f9e434f3e02890fcacfcb492e4
> Author: Milian Wolff <mail@milianw.de>
> Date:   Mon May 18 10:52:29 2015 +0200
> 
> Fix compiler warning about potential truncation.
> 
> klocalizedstring.cpp:1126:46: warning: absolute value function 'abs'
> given an argument of type 'long' but has parameter of type 'int'
> which may cause truncation of value
> 
> kls.d->number = static_cast<pluraln>(abs(a));
> ^
> klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead
> 
> 
> Diffs
> -----
> 
> src/klocalizedstring.cpp 910f44d 
> 
> Diff: https://git.reviewboard.kde.org/r/123867/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
> 

--===============4678482730803290216==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123867/">https://git.reviewboard.kde.org/r/123867/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is incorrect.  std::abs comes from cstdlib, not cmath please fix accordingly.  I have \
it compiling here fine on my macbook with #include &lt;cstdlib&gt; instead of \
#include &lt;cmath&gt;</p></pre>  <br />

<p>- Allen Winter</p>

<br />
<p>On May 21st, 2015, 8:19 a.m. UTC, Bhushan Shah wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett \
Clark.</div> <div>By Bhushan Shah.</div>

<p style="color: grey;"><i>Updated May 21, 2015, 8:19 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/1/console

Follow up to,

commit 8d392e523e4556f9e434f3e02890fcacfcb492e4
Author: Milian Wolff &lt;mail@milianw.de&gt;
Date:   Mon May 18 10:52:29 2015 +0200

    Fix compiler warning about potential truncation.

    klocalizedstring.cpp:1126:46: warning: absolute value function &#39;abs&#39;
    given an argument of type &#39;long&#39; but has parameter of type &#39;int&#39;
    which may cause truncation of value

            kls.d-&gt;number = static_cast&lt;pluraln&gt;(abs(a));
                                                 ^
    klocalizedstring.cpp:1126:46: note: use function &#39;std::abs&#39; instead</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/klocalizedstring.cpp <span style="color: grey">(910f44d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123867/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4678482730803290216==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 