--===============8566523616676070139== Content-Type: multipart/alternative; boundary="===============4678482730803290216==" --===============4678482730803290216== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/#review80817 ----------------------------------------------------------- This is incorrect. std::abs comes from cstdlib, not cmath please fix accordingly. I have it compiling here fine on my macbook with #include instead of #include - Allen Winter On May 21, 2015, 8:19 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123867/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 8:19 a.m.) > > > Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett Clark. > > > Repository: ki18n > > > Description > ------- > > https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/1/console > > Follow up to, > > commit 8d392e523e4556f9e434f3e02890fcacfcb492e4 > Author: Milian Wolff > Date: Mon May 18 10:52:29 2015 +0200 > > Fix compiler warning about potential truncation. > > klocalizedstring.cpp:1126:46: warning: absolute value function 'abs' > given an argument of type 'long' but has parameter of type 'int' > which may cause truncation of value > > kls.d->number = static_cast(abs(a)); > ^ > klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead > > > Diffs > ----- > > src/klocalizedstring.cpp 910f44d > > Diff: https://git.reviewboard.kde.org/r/123867/diff/ > > > Testing > ------- > > > Thanks, > > Bhushan Shah > > --===============4678482730803290216== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/

This is incorrect. std::abs comes from cstdlib, not cmath please fix accordingly. I have it compiling here fine on my macbook with #include <cstdlib> instead of #include <cmath>

- Allen Winter

On May 21st, 2015, 8:19 a.m. UTC, Bhushan Shah wrote:

Review request for KDE Frameworks, Marko Käning, Milian Wolff, and Scarlett Clark.

By Bhushan Shah.

Updated May 21, 2015, 8:19 a.m.

Repository: ki18n

Description

https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/1/console

Follow up to,

commit 8d392e523e4556f9e434f3e02890fcacfcb492e4
Author: Milian Wolff <mail@milianw.de>
Date:   Mon May 18 10:52:29 2015 +0200

    Fix compiler warning about potential truncation.
    
    klocalizedstring.cpp:1126:46: warning: absolute value function 'abs'
    given an argument of type 'long' but has parameter of type 'int'
    which may cause truncation of value
    
            kls.d->number = static_cast<pluraln>(abs(a));
                                                 ^
    klocalizedstring.cpp:1126:46: note: use function 'std::abs' instead

Diffs

src/klocalizedstring.cpp (910f44d)

--===============4678482730803290216==-- --===============8566523616676070139== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============8566523616676070139==--