[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 122987: Allow user to specify path to myspell dictionary files
From:       "Christophe Giboudeaux" <cgiboudeaux () gmx ! com>
Date:       2015-03-17 17:05:46
Message-ID: 20150317170546.15053.34497 () mimi ! kde ! org
[Download RAW message or body]

--===============4937022275702000169==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77647
-----------------------------------------------------------



src/plugins/hunspell/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122987/#comment53313>

    So you change an hardcoded path by a user chosen hardcoded one ?
    
    looking at the hunspell -D output, it looks like hunspell looks in more than one directory.
    
    hunspell -D
    
    [cut]
    
    AVAILABLE DICTIONARIES (path is not mandatory for -d option):
    /usr/share/hunspell/fr_FR
    /usr/share/hunspell/fr
    /usr/share/hunspell/en_US
    /usr/share/myspell/fr_FR
    /usr/share/myspell/hyph_en_US
    /usr/share/myspell/hyph_fr
    /usr/share/myspell/fr
    /usr/share/myspell/hyph_fr_FR
    /usr/share/myspell/en_US
    LOADED DICTIONARY:
    /usr/share/hunspell/fr_FR.aff
    /usr/share/hunspell/fr_FR.dic



src/plugins/hunspell/CMakeLists.txt
<https://git.reviewboard.kde.org/r/122987/#comment53312>

    endif()


- Christophe Giboudeaux


On March 17, 2015, 1:09 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 1:09 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/,  which is hardcoded \
> in the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user \
> define this path. 
> 
> Diffs
> -----
> 
> src/plugins/hunspell/CMakeLists.txt 098fb49 
> src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION 
> src/plugins/hunspell/hunspellclient.cpp 9e3aa67 
> src/plugins/hunspell/hunspelldict.cpp 621113d 
> 
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
> 
> 
> Testing
> -------
> 
> hunspell plugin began to work on Gentoo
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
> 


--===============4937022275702000169==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122987/">https://git.reviewboard.kde.org/r/122987/</a>
     </td>
    </tr>
   </table>
   <br />











<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line7" style="color: black; \
font-weight: bold; text-decoration: underline;">src/plugins/hunspell/CMakeLists.txt</a>  <span \
style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">7</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">if</span><span \
class="p">(</span><span class="s">NOT</span> <span class="s">DEFINED</span> <span \
class="s">MYSPELL_DICTS_PATH</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So you change an hardcoded path by a user chosen hardcoded one ?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">looking \
at the hunspell -D output, it looks like hunspell looks in more than one directory.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hunspell \
-D</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">[cut]</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">AVAILABLE DICTIONARIES (path is not mandatory for -d \
                option):
/usr/share/hunspell/fr_FR
/usr/share/hunspell/fr
/usr/share/hunspell/en_US
/usr/share/myspell/fr_FR
/usr/share/myspell/hyph_en_US
/usr/share/myspell/hyph_fr
/usr/share/myspell/fr
/usr/share/myspell/hyph_fr_FR
/usr/share/myspell/en_US
LOADED DICTIONARY:
/usr/share/hunspell/fr_FR.aff
/usr/share/hunspell/fr_FR.dic</p></pre>
 </div>
</div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line9" style="color: black; \
font-weight: bold; text-decoration: underline;">src/plugins/hunspell/CMakeLists.txt</a>  <span \
style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">9</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">endif</span><span \
class="p">(</span><span class="s">NOT</span> <span class="s">DEFINED</span> <span \
class="s">MYSPELL_DICTS_PATH</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">endif()</p></pre>  </div>
</div>
<br />



<p>- Christophe Giboudeaux</p>


<br />
<p>On March 17th, 2015, 1:09 p.m. UTC, Eugene Shalygin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Eugene Shalygin.</div>


<p style="color: grey;"><i>Updated March 17, 2015, 1:09 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Not on all systems myspell dictionaries are \
located in /usr/share/myspell/dicts/,  which is hardcoded in the hunspell plugin sources. For instance, \
on Gentoo it is /usr/share/myspell/. So let the user define this path.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">hunspell plugin began to work on \
Gentoo</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plugins/hunspell/CMakeLists.txt <span style="color: grey">(098fb49)</span></li>

 <li>src/plugins/hunspell/config-hunspellplugin.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/plugins/hunspell/hunspellclient.cpp <span style="color: grey">(9e3aa67)</span></li>

 <li>src/plugins/hunspell/hunspelldict.cpp <span style="color: grey">(621113d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122987/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============4937022275702000169==--


[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic