[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 122987: Allow user to specify path to myspell dictionary files
From: "Eugene Shalygin" <eugene.shalygin () gmail ! com>
Date: 2015-03-17 17:15:01
Message-ID: 20150317171501.15053.75259 () mimi ! kde ! org
[Download RAW message or body]
--===============7870385199587332063==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote:
> > src/plugins/hunspell/CMakeLists.txt, line 7
> > <https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line7>
> >
> > So you change an hardcoded path by a user chosen hardcoded one ?
> >
> > looking at the hunspell -D output, it looks like hunspell looks in more than one directory.
> >
> > hunspell -D
> >
> > [cut]
> >
> > AVAILABLE DICTIONARIES (path is not mandatory for -d option):
> > /usr/share/hunspell/fr_FR
> > /usr/share/hunspell/fr
> > /usr/share/hunspell/en_US
> > /usr/share/myspell/fr_FR
> > /usr/share/myspell/hyph_en_US
> > /usr/share/myspell/hyph_fr
> > /usr/share/myspell/fr
> > /usr/share/myspell/hyph_fr_FR
> > /usr/share/myspell/en_US
> > LOADED DICTIONARY:
> > /usr/share/hunspell/fr_FR.aff
> > /usr/share/hunspell/fr_FR.dic
On my system all dictionary files outside of /usr/share/hunspell/ are symlinks to files in this \
directory. Do you think it would be better to use (existent?) directories from 'SEARCH PATH:' section of \
hunspell -D output?
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77647
-----------------------------------------------------------
On Березень 17, 2015, 2:09 після полудня, Eugene Shalygin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122987/
> -----------------------------------------------------------
>
> (Updated Березень 17, 2015, 2:09 після полудня)
>
>
> Review request for KDE Frameworks and kdelibs.
>
>
> Repository: sonnet
>
>
> Description
> -------
>
> Not on all systems myspell dictionaries are located in /usr/share/myspell/dicts/, which is hardcoded \
> in the hunspell plugin sources. For instance, on Gentoo it is /usr/share/myspell/. So let the user \
> define this path.
>
> Diffs
> -----
>
> src/plugins/hunspell/CMakeLists.txt 098fb49
> src/plugins/hunspell/config-hunspellplugin.h.cmake PRE-CREATION
> src/plugins/hunspell/hunspellclient.cpp 9e3aa67
> src/plugins/hunspell/hunspelldict.cpp 621113d
>
> Diff: https://git.reviewboard.kde.org/r/122987/diff/
>
>
> Testing
> -------
>
> hunspell plugin began to work on Gentoo
>
>
> Thanks,
>
> Eugene Shalygin
>
>
--===============7870385199587332063==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122987/">https://git.reviewboard.kde.org/r/122987/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Березень 17th, 2015, 6:05 після полудня CET, \
<b>Christophe Giboudeaux</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line7" style="color: black; \
font-weight: bold; text-decoration: underline;">src/plugins/hunspell/CMakeLists.txt</a> <span \
style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">7</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">if</span><span \
class="p">(</span><span class="s">NOT</span> <span class="s">DEFINED</span> <span \
class="s">MYSPELL_DICTS_PATH</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So you change an hardcoded path by a user chosen hardcoded one ?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">looking \
at the hunspell -D output, it looks like hunspell looks in more than one directory.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hunspell \
-D</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">[cut]</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">AVAILABLE DICTIONARIES (path is not mandatory for -d \
option):
/usr/share/hunspell/fr_FR
/usr/share/hunspell/fr
/usr/share/hunspell/en_US
/usr/share/myspell/fr_FR
/usr/share/myspell/hyph_en_US
/usr/share/myspell/hyph_fr
/usr/share/myspell/fr
/usr/share/myspell/hyph_fr_FR
/usr/share/myspell/en_US
LOADED DICTIONARY:
/usr/share/hunspell/fr_FR.aff
/usr/share/hunspell/fr_FR.dic</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">On my system all dictionary files outside of \
/usr/share/hunspell/ are symlinks to files in this directory. Do you think it would be better to use \
(existent?) directories from 'SEARCH PATH:' section of hunspell -D output?</p></pre> <br />
<p>- Eugene</p>
<br />
<p>On Березень 17th, 2015, 2:09 після полудня CET, Eugene Shalygin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and kdelibs.</div>
<div>By Eugene Shalygin.</div>
<p style="color: grey;"><i>Updated Березень 17, 2015, 2:09 після полудня</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
sonnet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Not on all systems myspell dictionaries are \
located in /usr/share/myspell/dicts/, which is hardcoded in the hunspell plugin sources. For instance, \
on Gentoo it is /usr/share/myspell/. So let the user define this path.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">hunspell plugin began to work on \
Gentoo</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/hunspell/CMakeLists.txt <span style="color: grey">(098fb49)</span></li>
<li>src/plugins/hunspell/config-hunspellplugin.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/plugins/hunspell/hunspellclient.cpp <span style="color: grey">(9e3aa67)</span></li>
<li>src/plugins/hunspell/hunspelldict.cpp <span style="color: grey">(621113d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122987/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7870385199587332063==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic