[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: KPeople part of KDE Frameworks
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2015-02-17 18:56:49
Message-ID: 3612820.lUDvXmaTIo () xps
[Download RAW message or body]

El Divendres, 13 de febrer de 2015, a les 14:25:33, Aleix Pol va escriure:
> Hi,
> I would like to submit KPeople for review process so it can join the
> KF5 family in the next 5.8 release.
> 
> KPeople is a tier 3 framework (because of KService, which will be
> dropped eventually, without breaking ABI) and it offers cross-source
> contact aggregation. More information about it can be read on the
> README [1].
> 
> Your reviews will be welcome.

Please fix

./src/widgets/plugins/emaildetailswidget.cpp:50:    return i18n("Email");
./src/match.cpp:55:            ret += i18n("E-mail");

Also add context to make it clear if it's an action or a noun.

Cheers,
  Albert

> 
> Thanks!
> Aleix
> 
> [1]
> https://projects.kde.org/projects/playground/network/kpeople/repository/rev
> isions/master/entry/README.md

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]